Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752977AbbFGJRw (ORCPT ); Sun, 7 Jun 2015 05:17:52 -0400 Received: from rhlx01.hs-esslingen.de ([129.143.116.10]:56434 "EHLO rhlx01.hs-esslingen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767AbbFGJRo (ORCPT ); Sun, 7 Jun 2015 05:17:44 -0400 Date: Sun, 7 Jun 2015 11:17:42 +0200 From: Andreas Mohr To: lucas.de.marchi@gmail.com Cc: linux-modules@vger.kernel.org, Rusty Russell , Andreas Mohr , Andrew Morton , Bertrand Jacquin , "Marco d'Itri" , lkml , Kay Sievers , Lucas De Marchi Subject: Re: [PATCH kmod 3/3] tools: display features together with version information Message-ID: <20150607091742.GA8285@rhlx01.hs-esslingen.de> References: <1433658449-3931-1-git-send-email-lucas.de.marchi@gmail.com> <1433658449-3931-4-git-send-email-lucas.de.marchi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433658449-3931-4-git-send-email-lucas.de.marchi@gmail.com> X-Priority: none User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1362 Lines: 43 Hi, On Sun, Jun 07, 2015 at 03:27:29AM -0300, lucas.de.marchi@gmail.com wrote: > From: Lucas De Marchi > diff --git a/tools/kmod.c b/tools/kmod.c > index c9d2cc8..28217df 100644 > --- a/tools/kmod.c > +++ b/tools/kmod.c > @@ -114,6 +114,7 @@ static int handle_kmod_commands(int argc, char *argv[]) > return EXIT_SUCCESS; > case 'V': > puts("kmod version " VERSION); > + puts(KMOD_FEATURES); > return EXIT_SUCCESS; Hmm - seems kmod.c is the only component which open-codes literals rather than making use of PACKAGE define? If this is not intended, then it would probably be useful to have another correction commit prior to this one included in the series, to have this one gain properly fully symmetric content. > diff --git a/tools/modinfo.c b/tools/modinfo.c > index 94d55c9..86ac04b 100644 > --- a/tools/modinfo.c > +++ b/tools/modinfo.c > @@ -405,6 +405,7 @@ static int do_modinfo(int argc, char *argv[]) > return EXIT_SUCCESS; > case 'V': > puts(PACKAGE " version " VERSION); > + puts(KMOD_FEATURES); > return EXIT_SUCCESS; Thanks, Andreas Mohr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/