Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753082AbbFGM6a (ORCPT ); Sun, 7 Jun 2015 08:58:30 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:36825 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbbFGM6W (ORCPT ); Sun, 7 Jun 2015 08:58:22 -0400 Date: Sun, 7 Jun 2015 14:58:16 +0200 From: Ingo Molnar To: Andy Lutomirski Cc: "H. Peter Anvin" , Borislav Petkov , "linux-kernel@vger.kernel.org" , Denys Vlasenko , Brian Gerst , Peter Zijlstra , Linus Torvalds , Oleg Nesterov , Thomas Gleixner Subject: Re: [RFC PATCH] Rename ia32entry.S to entry_64_compat_32.S Message-ID: <20150607125816.GA6335@gmail.com> References: <1433509230-22238-1-git-send-email-mingo@kernel.org> <20150605133714.GH3679@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 30 * Andy Lutomirski wrote: > On Fri, Jun 5, 2015 at 2:09 PM, H. Peter Anvin wrote: > > Call it sys if it is now only the system call entry points. Agreed with _64_compat too. > > > > Breaking up these snarls of spaghetti assembly will be a blessing. > > I'm not too picky about what we call it or whether we merge it with entry_64.S. > *However*, I think the file name should end in _64.S. The whole arch/x86 tree is > arranged such that files that end in _64.S or _64.c are build for 64-bit kernels > and not for 32-bit kernels. I see no reason to deviate from that. > > FWIW, I'm eventually planning to completely rewrite the compat entry points to > use the new (RFC patches coming in a week or two I hope!) C exit code with > opportunistic sysretl at the end. I'm guessing the result will be about half > the size of the current code, and it'll be comprehensible to mere mortals. Ok, so I think the best is if I leave it alone for now: I've renamed it to entry_64_compat.S as per Boris's and hpa's suggestion, but won't merge it into entry_64.S (yet), let's see how your C conversion works out! Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/