Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752412AbbFGQ7j (ORCPT ); Sun, 7 Jun 2015 12:59:39 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:33675 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435AbbFGQ7b (ORCPT ); Sun, 7 Jun 2015 12:59:31 -0400 From: Grant Likely Subject: Re: [PATCH 2/2] of/platform: Mark all device tree resources as SHARED To: Ricardo Ribalda Delgado , Rob Herring Cc: Rob Herring , Andrew Morton , Bjorn Helgaas , Vivek Goyal , Jakub Sitnicki , Mike Travis , Jiang Liu , Thierry Reding , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Tejun Heo , Cliff Wickman In-Reply-To: References: <1433501478-15164-1-git-send-email-ricardo.ribalda@gmail.com> <1433501478-15164-2-git-send-email-ricardo.ribalda@gmail.com> Date: Sun, 07 Jun 2015 15:01:37 +0100 Message-Id: <20150607140138.026C4C412C8@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1846 Lines: 46 On Fri, 5 Jun 2015 18:51:36 +0200 , Ricardo Ribalda Delgado wrote: > Hello Rob, > > Thanks for your feedback! > > On Fri, Jun 5, 2015 at 6:45 PM, Rob Herring wrote: > > On Fri, Jun 5, 2015 at 5:51 AM, Ricardo Ribalda Delgado > > wrote: > >> Some device tree platform do not define their resources properly. i.e. > >> overlapping or repeated resources. > >> > >> This patch mark all device tree resources as shareable. > >> > >> In the future this should only be set for the platforms that have > >> problems. > > > > I don't think we want to do this globally. This should be very rare > > and we want to discourage any new cases. > > I just wanted to mimic the original behaviour. Unfortunately I have no > idea of what platform is broken. Grant needs to help us here :) I know of powerpc platforms that split the ethernet and mdio controllers into separate nodes, even though they share a register block. Those ones are broken (ie. mpc5200). I know there are ARM platforms that exhibited the same behaviour, but I can't remember specifics at the moment. > What do you think about the new flag? Does it make any sense for you? I think I have another solution to the whole problem. IIUC, the problem is the kernel crashes on unregistering resources. I've got a patch that doesn't try to unregister resources that weren't registered in the first place. It doesn't fix the problem of DT not registering the resources in the first place, but it makes the unregister path safe. I'll cc: you on the patch series. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/