Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751910AbbFGTTi (ORCPT ); Sun, 7 Jun 2015 15:19:38 -0400 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:58760 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbbFGTTc (ORCPT ); Sun, 7 Jun 2015 15:19:32 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 07 Jun 2015 21:19:31 +0200 X-ME-IP: 90.5.12.87 From: Robert Jarzmik To: Guennadi Liakhovetski Cc: Mauro Carvalho Chehab , Jiri Kosina , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Mack , Robert Jarzmik Subject: Re: [PATCH 4/4] media: pxa_camera: conversion to dmaengine References: <1426980085-12281-1-git-send-email-robert.jarzmik@free.fr> <1426980085-12281-5-git-send-email-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Sun, 07 Jun 2015 21:17:49 +0200 In-Reply-To: (Guennadi Liakhovetski's message of "Thu, 4 Jun 2015 13:20:33 +0200 (CEST)") Message-ID: <87oakr49b6.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 28 Guennadi Liakhovetski writes: > Hi Robert, > > Please, correct me if I am wrong, but doesn't this patch have to be > updates? Elgl looking at this: >> + for (i = 0; i < 3 && buf->descs[i]; i++) { >> + async_tx_ack(buf->descs[i]); >> + dmaengine_tx_release(buf->descs[i]); > > hasn't the addition of your proposed dmaengine_tx_release() API been > rejected? I'll wait for an updated version then. Yeah, correct. The updated version will just remove the dmaengine_tx_release() call, the async_tx_ack() is sufficient. I hope this won't stop the review, it's the only change I have so far in my tree on top of the submission. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/