Message-ID: <55749CC7.9020003@gmail.com>
Date: Sun, 07 Jun 2015 21:34:31 +0200
From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Dan Carpenter <dan.carpenter@oracle.com>
CC: gregkh@linuxfoundation.org, joe@perches.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/11] staging: rtl8192e: Remove dead code: rtl_dm.[ch]
References: <1433278095-13988-1-git-send-email-mateusz.kulikowski@gmail.com> <1433278095-13988-7-git-send-email-mateusz.kulikowski@gmail.com> <20150604135208.GF28762@mwanda>
In-Reply-To: <20150604135208.GF28762@mwanda>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1406
Lines: 36

On 04.06.2015 15:52, Dan Carpenter wrote:
> On Tue, Jun 02, 2015 at 10:48:10PM +0200, Mateusz Kulikowski wrote:
>> - Remove unused fields in dig_t structures. Some of them were only
>>   initialized and never accessed.
>> - Remove unused enums/macros/defines in rtl_dm.h
>> - Remove duplicated function declarations
>> - Remove unused dm_change_dynamic_initgain_thresh() function
>> - Remove unused dm_shadow_init() function
> 
> Could you delete dm_shadow[] in a follow on patch.
Will do in v2

> 
> How I review these sorts of patches is that:
> 1) Ignore deleted variables.  If those are used then it will cause a
>    compile problem so I don't worry about it.
> 
> 2) Verify that when we delete initialization, then we also delete the
>    variable.  In this case we deleted the initialization of dm_shadow[]
>    but not the variable itself, so I wondered if we were using
>    unitialized data.  It turns out that it was just an oversight.
> 
> Reviewing these means a lot of searching, for each variable.  Next time
> if the patch were split up more it would make it a bit easier.

Ok; I assume this applies for next series, not v2.


Regards,
Mateusz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/