Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751679AbbFGU6t (ORCPT ); Sun, 7 Jun 2015 16:58:49 -0400 Received: from mga09.intel.com ([134.134.136.24]:26949 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbbFGU6l convert rfc822-to-8bit (ORCPT ); Sun, 7 Jun 2015 16:58:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,569,1427785200"; d="scan'208";a="706952745" From: "Drokin, Oleg" To: Julia Lawall CC: "Dilger, Andreas" , Greg Kroah-Hartman , "" , "" , "" Subject: Re: lustre: question about lov_request.c Thread-Topic: lustre: question about lov_request.c Thread-Index: AQHQoV4qFqG7+2nNpUG2+M7qHGdm1Z2h/BOA Date: Sun, 7 Jun 2015 20:58:40 +0000 Message-ID: <4ED30946-5333-4684-9498-B734D991847A@intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.2.85] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 35 Hello! You are right, set_pga seems to be a dead member. It was alive a once, but somehow not fully removed now, so it's safe to drop the whole if and also the struct member itself. set_oabufs could be dropped as well. Thanks. Bye, Oleg On Jun 7, 2015, at 4:11 PM, Julia Lawall wrote: > Hello, > > The function lov_finish_set in > drivers/staging/lustre/lustre/lov/lov_request.c contains the code: > > if (set->set_pga) { > int len = set->set_oabufs * sizeof(*set->set_pga); > OBD_FREE_LARGE(set->set_pga, len); > } > > If I change the call to OBD_FREE_LARGE to kvfree, then len is not useful > any more. But actually, at least with grep, I can't find anywhere that > either the set_pga field or the set_oabufs field is set. Am I missing > something, or can the whole if be removed? Can these two fields go too? > > thanks, > julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/