Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751761AbbFGVGm (ORCPT ); Sun, 7 Jun 2015 17:06:42 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:25545 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbbFGVGe (ORCPT ); Sun, 7 Jun 2015 17:06:34 -0400 X-IronPort-AV: E=Sophos;i="5.13,569,1427752800"; d="scan'208";a="163756824" Date: Sun, 7 Jun 2015 23:06:32 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: "Drokin, Oleg" cc: Julia Lawall , "Dilger, Andreas" , Greg Kroah-Hartman , "" , "" , "" Subject: Re: lustre: question about lov_request.c In-Reply-To: <4ED30946-5333-4684-9498-B734D991847A@intel.com> Message-ID: References: <4ED30946-5333-4684-9498-B734D991847A@intel.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1285 Lines: 43 On Sun, 7 Jun 2015, Drokin, Oleg wrote: > Hello! > > You are right, set_pga seems to be a dead member. It was alive a once, but somehow not fully removed now, > so it's safe to drop the whole if and also the struct member itself. > set_oabufs could be dropped as well. Thanks. I will do that. julia > > Thanks. > > Bye, > Oleg > On Jun 7, 2015, at 4:11 PM, Julia Lawall wrote: > > > Hello, > > > > The function lov_finish_set in > > drivers/staging/lustre/lustre/lov/lov_request.c contains the code: > > > > if (set->set_pga) { > > int len = set->set_oabufs * sizeof(*set->set_pga); > > OBD_FREE_LARGE(set->set_pga, len); > > } > > > > If I change the call to OBD_FREE_LARGE to kvfree, then len is not useful > > any more. But actually, at least with grep, I can't find anywhere that > > either the set_pga field or the set_oabufs field is set. Am I missing > > something, or can the whole if be removed? Can these two fields go too? > > > > thanks, > > julia > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/