Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752061AbbFHDsZ (ORCPT ); Sun, 7 Jun 2015 23:48:25 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:58290 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751253AbbFHDsP (ORCPT ); Sun, 7 Jun 2015 23:48:15 -0400 Date: Sun, 7 Jun 2015 22:45:40 -0500 From: Felipe Balbi To: Pavel Machek CC: NeilBrown , Kishon Vijay Abraham I , NeilBrown , , GTA04 owners , Tony Lindgren , Subject: Re: [PATCH 5/6] phy: twl4030-usb: add support for reading resistor on ID pin. Message-ID: <20150608034540.GB6129@saruman.tx.rr.com> Reply-To: References: <20150416075945.23307.24424.stgit@notabene.brown> <20150416080304.23307.41913.stgit@notabene.brown> <556C5FF4.3050603@ti.com> <20150602073731.26edbd3b@notabene.brown> <20150606131009.GD1329@xo-6d-61-c0.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7iMSBzlTiPOCCT2k" Content-Disposition: inline In-Reply-To: <20150606131009.GD1329@xo-6d-61-c0.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3300 Lines: 98 --7iMSBzlTiPOCCT2k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 06, 2015 at 03:10:09PM +0200, Pavel Machek wrote: > On Tue 2015-06-02 07:37:31, NeilBrown wrote: > > On Mon, 1 Jun 2015 19:06:52 +0530 Kishon Vijay Abraham I > > wrote: > >=20 > > > Hi, > > >=20 > > > On Thursday 16 April 2015 01:33 PM, NeilBrown wrote: > > > > From: NeilBrown > > > > > > > > The twl4030 phy can measure, with low precision, the > > > > resistance-to-ground of the ID pin. > > > > > > > > Add a function to read the value, and export the result > > > > via sysfs. > > >=20 > > > Little sceptical about adding new sysfs entries. Do you have a good r= eason to=20 > > > add this? > >=20 > > The hardware can report the value, so why not present it to user-space? > >=20 > > I originally used this with a udev rule which would configure the maxim= um > > current based on the resistance measure - to work with the particular c= harger > > hardware I have. > >=20 > > More recent patches try to do all of the max-current configuration in t= he > > kernel, so I could live without exporting the value via sysfs if that i= s a > > show-stopper. > >=20 > > I can't see where the scepticism comes from though. It is a well defin= ed > > and cleary documented feature of the hardware. Why not expose it? >=20 > sysfs interface is supposed to work for different chargers, without users= pace > noticing. >=20 > Are these values the ones that are likely to be useful there? These values come from Battery Charger specification 1.1+, IIRC, so no other values should show up unless documented in future BC revisions. > > > > + Possible values are: > > > > + ground > > > > + 102k > > > > + 200k > > > > + 440k > > > > + floating > > > > + unknown >=20 > ...or would it make more sense to export for example numerical ohms, as t= hat's > what are other chargers likely to provide? How do you expose "floating" in Ohms ? UINT_MAX might be one way, but that would have to be documented. --=20 balbi --7iMSBzlTiPOCCT2k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVdQ/kAAoJEIaOsuA1yqREJScP/27qLOuShQJVwnr1zLDvC0Pb Ckp5hRJ9/mecxkXMwjnE4UsOpmegmMPPEcWOU1ocJ1Ado/KEYmRUAaMgy2JAO+MP iWSJWNZqcs/Rq5/O0c7dqFcnlsYWRhuOKoUPUlZuMbCU7jy6SCUGC6QPwHpgegHI LkmaAWNOUKbd4UE9q8ax0RgV+32EyBYwi05NlIFJA97nBRdNVCfu9fqVwxSDlUg2 8ncBYlY78nfSH+y7WWnlZ8AzJgXu7wX1fNc6TTmVrdIvtNn1R0/cgsweLe8Du/xU x4oVKHMbeSB4+8nTX964AXr+n8Y+G9nUdYnSnqugRfv5nCU2aXYnDpZXXuUuj0pr 97GGuuYwhAOLzsqwLH/wyz70aXY8chd0Yik6P+j9S559qNwvWF1Qe1FaS000Ihg+ zqs+wl12YIO3aF3G6iDytVQKz2SYnVLTGrPgdBln//XJfdHISMFChdjnoKyRqHE6 3D9bM9IZPp3G9ZmiVAo5NbObNIfGmAddamB4SFa8a8Qt75puFqb9eGtnV8uTycjo /VxB7+oTPMK0NwD+Ukvxgg/pm2N1QUSguwpthps+/7agYnPlvqLkQXWr5JJy/pLT LFGS6L9huCrz1aYPGSRVv6KvdDZbCsAGrXWEho9DG0EMPd7tz0piONjQkhHPVCDD xBkUMM6nDTLVqBo6Tk01 =7Qs6 -----END PGP SIGNATURE----- --7iMSBzlTiPOCCT2k-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/