Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751499AbbFHEkj (ORCPT ); Mon, 8 Jun 2015 00:40:39 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34258 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762AbbFHEkd (ORCPT ); Mon, 8 Jun 2015 00:40:33 -0400 Date: Mon, 8 Jun 2015 10:07:53 +0530 From: maitysanchayan@gmail.com To: Maxime Ripard Cc: arnd@arndb.de, shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, stefan@agner.ch, kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/2] ARM: dts: vfxxx: Add OCOTP and OCROM nodes Message-ID: <20150608043753.GA3497@Sanchayan-Arch.toradex.int> References: <20150606115833.GP23777@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150606115833.GP23777@lukather> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1924 Lines: 50 Hello Maxime, On 15-06-06 13:58:33, Maxime Ripard wrote: > Hi, > > On Fri, Jun 05, 2015 at 02:52:37PM +0530, Sanchayan Maity wrote: > > Add a device tree node for the On-Chip One Time Programmable > > Controller (OCOTP) and the On-Chip ROM. > > > > Signed-off-by: Sanchayan Maity > > --- > > arch/arm/boot/dts/vfxxx.dtsi | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi > > index 2f4b04d..ed9b6b8 100644 > > --- a/arch/arm/boot/dts/vfxxx.dtsi > > +++ b/arch/arm/boot/dts/vfxxx.dtsi > > @@ -56,6 +56,13 @@ > > compatible = "simple-bus"; > > interrupt-parent = <&mscm_ir>; > > ranges; > > + ocotp-cfg = <&ocotp 0x410 0x420>; > > + rom-revision = <&ocrom 0x80>; > > + > > + ocrom: ocrom { > > + compatible = "fsl,vf610-ocrom", "syscon"; > > + reg = <0x00000000 0x18000>; > > + }; > > Shouldn't that use the new nvmem framework currently being discussed, > instead of defining custom bindings? I am aware of those nvmem framework patches by Srinivas, however from what I can see that framework has not been merged yet atleast from the mail chain that I see for v5 of the patchset so I have not properly looked into that. Mark Brown did apply the regmap patches to his tree, but has the rest of the framework been merged or is it expected to be merged? If it is expected to be merged and if that framework is a fit for what we are trying to do here and it seems so on a quick glance, then I can go with that. However I still did like to hear from Arnd or have some more comments before I go for that approach with the next respin. - Sanchayan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/