Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751655AbbFHGWn (ORCPT ); Mon, 8 Jun 2015 02:22:43 -0400 Received: from mx0a-0016ce01.pphosted.com ([67.231.148.157]:51941 "EHLO mx0a-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762AbbFHGWi convert rfc822-to-8bit (ORCPT ); Mon, 8 Jun 2015 02:22:38 -0400 From: Nilesh Javali To: Nicholas Mc Guire , Dept-Eng QLogic Storage Upstream CC: "James E.J. Bottomley" , linux-scsi , linux-kernel Subject: RE: [PATCH] qla4xxx: pass timeout as HZ independent value Thread-Topic: [PATCH] qla4xxx: pass timeout as HZ independent value Thread-Index: AQHQmLpVdQ+HnmkIJUC454yZQ2/gmJ2iNPfQ Date: Mon, 8 Jun 2015 06:22:17 +0000 Message-ID: <058691E078642A44B7C96BB0B1DB4F2481C9EA26@avmb2.qlogic.org> References: <1432757426-6459-1-git-send-email-hofrat@osadl.org> In-Reply-To: <1432757426-6459-1-git-send-email-hofrat@osadl.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.4.10] disclaimer: bypass Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5700 definitions=7825 signatures=670588 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1506080119 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1960 Lines: 52 > -----Original Message----- > From: Nicholas Mc Guire [mailto:hofrat@osadl.org] > Sent: Thursday, May 28, 2015 1:40 AM > To: Dept-Eng QLogic Storage Upstream > Cc: James E.J. Bottomley; linux-scsi; linux-kernel; Nicholas Mc Guire > Subject: [PATCH] qla4xxx: pass timeout as HZ independent value > > schedule_timeout_* takes a timeout in jiffies but the code currently is > passing in a constant which makes this timeout HZ dependent, so pass it > through msecs_to_jiffies() to fix this up. > > patch was compile tested with x86_64_defconfig + SCSI_LOWLEVEL=y, > CONFIG_SCSI_QLA_ISCSI=m > > Patch is against 4.1-rc5 (localversion-next is -next-20150527) > > Signed-off-by: Nicholas Mc Guire > --- > > As there is no documentation of the intended timeout it might be wrong to > convert it with msecs_to_jiffies as this can reduces the actual jiffies value by > at least a factor of 10 - so someone that knows this driver needs to check on > the actual value - but in any case it needs to be passed in a HZ independent > way. > > drivers/scsi/qla4xxx/ql4_nx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c > index 7c33658..7b53eab 100644 > --- a/drivers/scsi/qla4xxx/ql4_nx.c > +++ b/drivers/scsi/qla4xxx/ql4_nx.c > @@ -1569,7 +1569,7 @@ static int qla4_82xx_cmdpeg_ready(struct > scsi_qla_host *ha, int pegtune_val) > (val == PHAN_INITIALIZE_ACK)) > return 0; > set_current_state(TASK_UNINTERRUPTIBLE); > - schedule_timeout(500); > + schedule_timeout(msecs_to_jiffies(500)); > > } while (--retries); > > -- > 1.7.10.4 Acked-by: Nilesh Javali -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/