Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752305AbbFHGwR (ORCPT ); Mon, 8 Jun 2015 02:52:17 -0400 Received: from mail-vn0-f45.google.com ([209.85.216.45]:34871 "EHLO mail-vn0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750964AbbFHGwH (ORCPT ); Mon, 8 Jun 2015 02:52:07 -0400 MIME-Version: 1.0 In-Reply-To: References: <1433683242-3945-1-git-send-email-linux.amoon@gmail.com> <5574F97A.5030104@samsung.com> Date: Mon, 8 Jun 2015 15:52:06 +0900 X-Google-Sender-Auth: HhSPbuo0mkCy4YyG0wE5rOQcsfU Message-ID: Subject: Re: [RESEND 1/2] usb: ehci-exynos: Make provision for vdd regulators From: Krzysztof Kozlowski To: Javier Martinez Canillas Cc: Krzysztof Kozlowski , Anand Moon , Mark Rutland , "devicetree@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Pawel Moll , Ian Campbell , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Linux Kernel , Felipe Balbi , Rob Herring , Alan Stern , Kukjin Kim , Kumar Gala , Jingoo Han , "linux-arm-kernel@lists.infradead.org" , Vivek Gautam Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1238 Lines: 39 2015-06-08 15:42 GMT+09:00 Javier Martinez Canillas : > Hello, > > On Mon, Jun 8, 2015 at 7:14 AM, Krzysztof Kozlowski > wrote: > > [...] > >> >> To summarize my point of view: >> 1. Unless Vivek's says otherwise, please give him the credits with >> proper "from" field. >> 2. Issues mentioned in previous mail should be addressed (missing >> IS_ERR(), how disabling the regulator during suspend affects waking >> up). >> 3. The patchset must be tested, even after rebasing. >> > > Agreed with all the points. > > Anand, > > An easy way to preserve authorship when rebasing patches is to use the > git command author option. As an example you can execute the following > command: > > $ git commit -a -s --author='Vivek Gautam ' By default "git am" and "git format-patch" preserve the author of a patch so usually this step is not necessary. Unless the patch is applied in a different way... :) Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/