Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752420AbbFHGyw (ORCPT ); Mon, 8 Jun 2015 02:54:52 -0400 Received: from mail-yh0-f50.google.com ([209.85.213.50]:34567 "EHLO mail-yh0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752097AbbFHGyo (ORCPT ); Mon, 8 Jun 2015 02:54:44 -0400 MIME-Version: 1.0 X-Originating-IP: [37.11.0.18] In-Reply-To: <1433727349-23330-1-git-send-email-k.kozlowski@samsung.com> References: <1433727349-23330-1-git-send-email-k.kozlowski@samsung.com> Date: Mon, 8 Jun 2015 08:54:44 +0200 Message-ID: Subject: Re: [PATCH] thermal: exynos: Disable the regulator on probe failure From: Javier Martinez Canillas To: Krzysztof Kozlowski Cc: Lukasz Majewski , Zhang Rui , Eduardo Valentin , Kukjin Kim , "linux-pm@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel , stable@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1426 Lines: 39 Hello Krzysztof, On Mon, Jun 8, 2015 at 3:35 AM, Krzysztof Kozlowski wrote: > During probe the regulator (if present) was enabled but not disabled in > case of failure. So an unsuccessful probe lead to enabling the > regulator which was actually not needed because the device was not > enabled. > > Additionally each deferred probe lead to increase of regulator enable > count so it would not be effectively disabled during removal of the > device. > > Signed-off-by: Krzysztof Kozlowski > Fixes: 498d22f616f6 ("thermal: exynos: Support for TMU regulator defined at device tree") > Cc: > Reviewed-by: Javier Martinez Canillas > --- > > I am not entirely convinced that this should go to stable. Leaving a > regulator enabled in case of probe failure (no exynos TMU device) or > after deferred probe (regulator won't be disabled during device removal) > is not a critical issue, just leaks power. Yes, as you said leaving the regulator enabled is not critical but OTOH is a very small patch and is fixing a very evident bug so I think it's OK. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/