Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752528AbbFHHMf (ORCPT ); Mon, 8 Jun 2015 03:12:35 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:36016 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752457AbbFHHMX (ORCPT ); Mon, 8 Jun 2015 03:12:23 -0400 From: Caesar Wang To: Heiko Stuebner Cc: dianders@chromium.org, Dmitry Torokhov , linux-rockchip@lists.infradead.org, Caesar Wang , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 2/3] ARM: rockchip: ensure CPU to enter WFI/WFE state Date: Mon, 8 Jun 2015 15:11:35 +0800 Message-Id: <1433747496-7642-3-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1433747496-7642-1-git-send-email-wxt@rock-chips.com> References: <1433747496-7642-1-git-send-email-wxt@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1385 Lines: 49 The patch can ensure that v7_exit_coherency_flush() in rockchip_cpu_die() executed in time. The mdelay(1) has enough time to fix the problem of CPU offlining. That's a workaround way in rockchip hotplug code, At least, we haven't a better way to solve it. Who know, that maybe fixed by chip (hardware) in the future. Signed-off-by: Caesar Wang Changes in v5: - Fix the patch decription. - Add the changelog. Changes in v4: None Changes in v3: None Changes in v2: None Changes in v2: - As Kever points out, Fix the subject typo WFI/WFE. --- arch/arm/mach-rockchip/platsmp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c index bd40852..5bc2a89 100644 --- a/arch/arm/mach-rockchip/platsmp.c +++ b/arch/arm/mach-rockchip/platsmp.c @@ -321,6 +321,9 @@ static void __init rockchip_smp_prepare_cpus(unsigned int max_cpus) #ifdef CONFIG_HOTPLUG_CPU static int rockchip_cpu_kill(unsigned int cpu) { + /* ensure CPU can enter the WFI/WFE state */ + mdelay(1); + pmu_set_power_domain(0 + cpu, false); return 1; } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/