Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752453AbbFHHY7 (ORCPT ); Mon, 8 Jun 2015 03:24:59 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:58175 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbbFHHYv (ORCPT ); Mon, 8 Jun 2015 03:24:51 -0400 X-IronPort-AV: E=Sophos;i="5.13,572,1427752800"; d="scan'208";a="135034927" Date: Mon, 8 Jun 2015 09:24:42 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: "Drokin, Oleg" cc: Julia Lawall , "Dilger, Andreas" , Greg Kroah-Hartman , "" , "" , "" Subject: Re: lustre: question about lov_request.c In-Reply-To: <4ED30946-5333-4684-9498-B734D991847A@intel.com> Message-ID: References: <4ED30946-5333-4684-9498-B734D991847A@intel.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 783 Lines: 22 > You are right, set_pga seems to be a dead member. It was alive a once, but somehow not fully removed now, > so it's safe to drop the whole if and also the struct member itself. > set_oabufs could be dropped as well. Looking further, in the same function I also don't see any other uses of the tested field in: if (req->rq_oi.oi_md) OBD_FREE_LARGE(req->rq_oi.oi_md, req->rq_buflen); if (set->set_lockh) lov_llh_put(set->set_lockh); Can these be dropped as well? thanks, julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/