Date: Mon, 8 Jun 2015 09:30:36 +0200
From: Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        Gabriele Mazzotta <gabriele.mzt@gmail.com>,
        Alex Hung <alex.hung@canonical.com>,
        Matthew Garrett <mjg59@srcf.ucam.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>, Valdis.Kletnieks@vt.edu
Subject: Re: [PATCH v5 0/3] Dell Airplane Mode Switch driver
Message-ID: <20150608073022.GA12078@pali>
References: <1416755361-17357-1-git-send-email-pali.rohar@gmail.com>
 <1433579010-10509-1-git-send-email-pali.rohar@gmail.com>
 <20150608041238.GA9930@fury.dvhart.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20150608041238.GA9930@fury.dvhart.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1503
Lines: 35

On Sunday 07 June 2015 21:12:38 Darren Hart wrote:
> On Sat, Jun 06, 2015 at 10:23:27AM +0200, Pali Rohár wrote:
> > This patch series add new acpi Dell Airplane Mode Switch driver (DELLABCE and
> > DELRBTN acpi devices). It provides radio HW switch events (together with current
> > state of radio devices) and export them via rfkill interface. These events are
> > also used in dell-laptop driver instead i8042 filter hook function (when acpi
> > device is available).
> > 
> > In v2 was added support for laptops which have toggle button instead HW slider
> > switch. For that I reused code done by Alex Hung.
> > 
> > v3 is just cleanup.
> > 
> > In v4 was fixed dependency problems.
> 
> Please be more specific in the future. You want people that haven't looked at
> this for a couple of weeks to be able to quickly identify what changed and
> confirm they agree. You want people to review your code, you want to reduce the
> barrier to do so. Easy to do while it's fresh in your mind.
> 
> Thanks for the update, I have these qeueud to testing.
> 

I wrote more details into individual patches above diffstat lines. But
if you want detailed description also to cover letter email, I can do
that in the future...

-- 
Pali Rohár
pali.rohar@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/