Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752540AbbFHH6e (ORCPT ); Mon, 8 Jun 2015 03:58:34 -0400 Received: from mga09.intel.com ([134.134.136.24]:53161 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752033AbbFHH60 convert rfc822-to-8bit (ORCPT ); Mon, 8 Jun 2015 03:58:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,573,1427785200"; d="scan'208";a="742852501" From: "Drokin, Oleg" To: Julia Lawall CC: "Dilger, Andreas" , Greg Kroah-Hartman , "" , "" , "" Subject: Re: lustre: question about lov_request.c Thread-Topic: lustre: question about lov_request.c Thread-Index: AQHQoV4qFqG7+2nNpUG2+M7qHGdm1Z2h/BOAgACu6ACAAAlngA== Date: Mon, 8 Jun 2015 07:58:21 +0000 Message-ID: <18F4A875-0EF0-4566-BF2D-344B3617C83E@intel.com> References: <4ED30946-5333-4684-9498-B734D991847A@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.2.85] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 946 Lines: 28 On Jun 8, 2015, at 3:24 AM, Julia Lawall wrote: >> You are right, set_pga seems to be a dead member. It was alive a once, but somehow not fully removed now, >> so it's safe to drop the whole if and also the struct member itself. >> set_oabufs could be dropped as well. > > Looking further, in the same function I also don't see any other uses of > the tested field in: > > if (req->rq_oi.oi_md) > OBD_FREE_LARGE(req->rq_oi.oi_md, req->rq_buflen); > > if (set->set_lockh) > lov_llh_put(set->set_lockh); > > Can these be dropped as well? Yes, these two seems to be on their way out too, so please feel free to remove them. Thanks. Bye, Oleg-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/