Message-ID: <55754C06.2020800@linaro.org>
Date: Mon, 08 Jun 2015 10:02:14 +0200
From: Eric Auger <eric.auger@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Paul Bolle <pebolle@tiscali.nl>
CC: eric.auger@st.com, linux-arm-kernel@lists.infradead.org,
        alex.williamson@redhat.com, b.reynal@virtualopensystems.com,
        christoffer.dall@linaro.org, linux-kernel@vger.kernel.org,
        patches@linaro.org, agraf@suse.de
Subject: Re: [PATCH v2 4/4] VFIO: platform: Calxeda xgmac reset module
References: <1433516792-16397-1-git-send-email-eric.auger@linaro.org>	 <1433516792-16397-5-git-send-email-eric.auger@linaro.org> <1433595457.10861.77.camel@x220>
In-Reply-To: <1433595457.10861.77.camel@x220>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 938
Lines: 35

Hi Paul,
On 06/06/2015 02:57 PM, Paul Bolle wrote:
> On Fri, 2015-06-05 at 17:06 +0200, Eric Auger wrote:
>> --- /dev/null
>> +++ b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c
> 
>> +static int __init vfio_platform_calxedaxgmac_init(void)
>> +{
>> +	return 0;
>> +}
>> +
>> +static void __exit vfio_platform_calxedaxgmac_exit(void)
>> +{
>> +}
>> +
>> +module_init(vfio_platform_calxedaxgmac_init);
>> +module_exit(vfio_platform_calxedaxgmac_exit);
> 
> Just a nit: I think it's OK to leave out these functions if they both do
> nothing. See delete_module in kernel/module.c.
Indeed it works fine without. Thank you for the information!

Best Regards

Eric
> 
> 
> Paul Bolle
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/