Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752864AbbFHIru (ORCPT ); Mon, 8 Jun 2015 04:47:50 -0400 Received: from mail.skyhub.de ([78.46.96.112]:44281 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353AbbFHIrm (ORCPT ); Mon, 8 Jun 2015 04:47:42 -0400 Date: Mon, 8 Jun 2015 10:47:40 +0200 From: Borislav Petkov To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Andy Lutomirski , Denys Vlasenko , Brian Gerst , Peter Zijlstra , "H. Peter Anvin" , Linus Torvalds , Oleg Nesterov , Thomas Gleixner Subject: Re: [PATCH 1/4] x86/asm/entry: Rename compat syscall entry points Message-ID: <20150608084740.GA3612@pd.tnic> References: <1433752501-15901-1-git-send-email-mingo@kernel.org> <1433752501-15901-2-git-send-email-mingo@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1433752501-15901-2-git-send-email-mingo@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2237 Lines: 63 On Mon, Jun 08, 2015 at 10:34:58AM +0200, Ingo Molnar wrote: > Rename the following system call entry points: > > ia32_cstar_target -> entry_SYSCALL_compat > ia32_syscall -> entry_INT80_compat > > The generic naming scheme for x86 system call entry points is: > > entry_MNEMONIC_qualifier > > where 'qualifier' is one of _32, _64 or _compat. > > Cc: Andy Lutomirski > Cc: Borislav Petkov > Cc: Brian Gerst > Cc: Denys Vlasenko > Cc: H. Peter Anvin > Cc: Linus Torvalds > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Ingo Molnar > --- > Documentation/x86/entry_64.txt | 4 ++-- > arch/x86/entry/entry_64_compat.S | 8 ++++---- > arch/x86/entry/syscall_32.c | 6 +++--- > arch/x86/include/asm/proto.h | 4 ++-- > arch/x86/kernel/asm-offsets_64.c | 2 +- > arch/x86/kernel/cpu/common.c | 2 +- > arch/x86/kernel/traps.c | 2 +- > arch/x86/xen/xen-asm_64.S | 2 +- > 8 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/Documentation/x86/entry_64.txt b/Documentation/x86/entry_64.txt > index 9132b86176a3..33884d156125 100644 > --- a/Documentation/x86/entry_64.txt > +++ b/Documentation/x86/entry_64.txt > @@ -18,10 +18,10 @@ The IDT vector assignments are listed in arch/x86/include/asm/irq_vectors.h. > > - system_call: syscall instruction from 64-bit code. > > - - ia32_syscall: int 0x80 from 32-bit or 64-bit code; compat syscall > + - entry_INT80_compat: int 0x80 from 32-bit or 64-bit code; compat syscall > either way. Haha, with the new naming scheme you don't even need the text anymore. entry_INT80_compat is already enough. :-) Looks like an improvement to me, at a quick glance. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/