Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752488AbbFHKxU (ORCPT ); Mon, 8 Jun 2015 06:53:20 -0400 Received: from mga14.intel.com ([192.55.52.115]:19004 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751906AbbFHKxM (ORCPT ); Mon, 8 Jun 2015 06:53:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,573,1427785200"; d="scan'208";a="739319860" From: Jani Nikula To: Ander Conselvan de Oliveira , ville.syrjala@linux.intel.com Cc: nkalkhof@web.de, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, torvalds@linux-foundation.org, Ander Conselvan de Oliveira , Stefan Lippers-Hollmann Subject: Re: [PATCH] drm/i915: Properly initialize SDVO analog connectors In-Reply-To: <1433751990-21544-1-git-send-email-ander.conselvan.de.oliveira@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20150607043253.12f4058e@mir> <1433751990-21544-1-git-send-email-ander.conselvan.de.oliveira@intel.com> User-Agent: Notmuch/0.19+112~g77230b0 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 08 Jun 2015 13:50:23 +0300 Message-ID: <87vbey8oeo.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1630 Lines: 48 On Mon, 08 Jun 2015, Ander Conselvan de Oliveira wrote: > In the commit below, I missed the connector allocation in the function > intel_sdvo_analog_init(), leading to those connectors to have a NULL > state pointer. > > commit 08d9bc920d465bbbbd762cac9383249c19bf69a2 > Author: Ander Conselvan de Oliveira > Date: Fri Apr 10 10:59:10 2015 +0300 > > drm/i915: Allocate connector state together with the connectors > > Signed-off-by: Ander Conselvan de Oliveira Pushed to drm-intel-fixes, thanks for the patch and testing. BR, Jani. > --- > drivers/gpu/drm/i915/intel_sdvo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c > index d24ef75..aa2fd75 100644 > --- a/drivers/gpu/drm/i915/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/intel_sdvo.c > @@ -2554,7 +2554,7 @@ intel_sdvo_analog_init(struct intel_sdvo *intel_sdvo, int device) > > DRM_DEBUG_KMS("initialising analog device %d\n", device); > > - intel_sdvo_connector = kzalloc(sizeof(*intel_sdvo_connector), GFP_KERNEL); > + intel_sdvo_connector = intel_sdvo_connector_alloc(); > if (!intel_sdvo_connector) > return false; > > -- > 2.1.0 > -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/