Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752978AbbFHLQB (ORCPT ); Mon, 8 Jun 2015 07:16:01 -0400 Received: from mga03.intel.com ([134.134.136.65]:65143 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751818AbbFHLPv (ORCPT ); Mon, 8 Jun 2015 07:15:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,573,1427785200"; d="scan'208";a="504728798" Date: Mon, 8 Jun 2015 16:46:58 +0530 From: Vinod Koul To: Jiang Liu Cc: Thomas Gleixner , Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , Randy Dunlap , Yinghai Lu , Borislav Petkov , Dan Williams , Philipp Zabel , Steve Longerbeam , Konrad Rzeszutek Wilk , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [RFT v2 11/48] ipu: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc Message-ID: <20150608111658.GL28601@localhost> References: <1433391238-19471-1-git-send-email-jiang.liu@linux.intel.com> <1433391238-19471-12-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433391238-19471-12-git-send-email-jiang.liu@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2462 Lines: 65 On Thu, Jun 04, 2015 at 12:13:21PM +0800, Jiang Liu wrote: > Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc while we > already have a pointer to corresponding irq_desc. > > Do the same thing to avoid pattern "irq_get_chip_data(data->irq)". And I am missing the context, it is a bad practice to send some part of the series without giving context. Is this dependent on something else...? -- ~Vinod > > Signed-off-by: Jiang Liu > --- > drivers/dma/ipu/ipu_irq.c | 2 +- > drivers/gpu/ipu-v3/ipu-common.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma/ipu/ipu_irq.c b/drivers/dma/ipu/ipu_irq.c > index 2e284a4438bc..0e12af37fe2f 100644 > --- a/drivers/dma/ipu/ipu_irq.c > +++ b/drivers/dma/ipu/ipu_irq.c > @@ -268,7 +268,7 @@ int ipu_irq_unmap(unsigned int source) > /* Chained IRQ handler for IPU error interrupt */ > static void ipu_irq_err(unsigned int irq, struct irq_desc *desc) > { > - struct ipu *ipu = irq_get_handler_data(irq); > + struct ipu *ipu = irq_desc_get_handler_data(desc); > u32 status; > int i, line; > > diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c > index 67bab5c36056..7022825b7a2c 100644 > --- a/drivers/gpu/ipu-v3/ipu-common.c > +++ b/drivers/gpu/ipu-v3/ipu-common.c > @@ -915,8 +915,8 @@ static void ipu_irq_handle(struct ipu_soc *ipu, const int *regs, int num_regs) > static void ipu_irq_handler(unsigned int irq, struct irq_desc *desc) > { > struct ipu_soc *ipu = irq_desc_get_handler_data(desc); > + struct irq_chip *chip = irq_desc_get_chip(desc); > const int int_reg[] = { 0, 1, 2, 3, 10, 11, 12, 13, 14}; > - struct irq_chip *chip = irq_get_chip(irq); > > chained_irq_enter(chip, desc); > > @@ -928,8 +928,8 @@ static void ipu_irq_handler(unsigned int irq, struct irq_desc *desc) > static void ipu_err_irq_handler(unsigned int irq, struct irq_desc *desc) > { > struct ipu_soc *ipu = irq_desc_get_handler_data(desc); > + struct irq_chip *chip = irq_desc_get_chip(desc); > const int int_reg[] = { 4, 5, 8, 9}; > - struct irq_chip *chip = irq_get_chip(irq); > > chained_irq_enter(chip, desc); > > -- > 1.7.10.4 > -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/