Date: Mon, 8 Jun 2015 13:29:17 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Alexander Holler <holler@ahsoftware.de>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Tejun Heo <htejun@gmail.com>, Louis Langholtz <lou_langholtz@me.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Trivial patch monkey <trivial@kernel.org>,
        Rusty Russell <rusty@rustcorp.com.au>,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Thomas Gleixner <tglx@linutronix.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] debug: Deprecate BUG_ON() use in new code, introduce
 CRASH_ON()
Message-ID: <20150608112917.GB20511@gmail.com>
References: <1433721270-9182-1-git-send-email-lou_langholtz@me.com>
 <20150608000007.GA3543@mtj.duckdns.org>
 <CA+55aFwmOGaP1DN3frkfP+Df=jCwURqO22A6-5GqpMnZXkvMXA@mail.gmail.com>
 <20150608071215.GA369@gmail.com>
 <557546E6.5030304@ahsoftware.de>
 <CAFLxGvzrSUfEV+LM26yy6aeA7hqGt0PnuuBD6rWDhRnivSRSmQ@mail.gmail.com>
 <5575558E.5070706@ahsoftware.de>
 <20150608090509.GA19160@gmail.com>
 <20150608091132.GA19566@gmail.com>
 <55755EBB.7020105@ahsoftware.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55755EBB.7020105@ahsoftware.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1111
Lines: 26


* Alexander Holler <holler@ahsoftware.de> wrote:

> > Also note that BUG_ON() will make data corruption _worse_ statistically. Why? 
> > Because most data corruptions are unlikely to be perfectly detected by a 
> > BUG_ON(), and the BUG_ON() delays the finding of the underlying bug, so the 
> > bug will hit more people before it's fixed for good.
> >
> > So even in the cases where you could argue that the system needs to stop, 
> > because we have evidence of data corruption, it's statistically the better 
> > approach to continue and get kernel log info back to developers.
> 
> Risking more, maybe even worse problems like corrupting file systems or similiar 
> in order to have a slightly chance of save log info?

That's not what I said - please read my argument and argue with that if you want, 
not with some other straw-man argument...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/