Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752908AbbFHLjD (ORCPT ); Mon, 8 Jun 2015 07:39:03 -0400 Received: from mail1.bemta5.messagelabs.com ([195.245.231.151]:61110 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526AbbFHLi6 convert rfc822-to-8bit (ORCPT ); Mon, 8 Jun 2015 07:38:58 -0400 X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-6.tower-179.messagelabs.com!1433763529!36086289!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Steve Twiss]" To: Dmitry Torokhov CC: Andrew Morton , Jiri Kosina , DT , David Dajun Chen , INPUT , Ian Campbell , Kumar Gala , LKML , Lee Jones , "Mark Rutland" , Pawel Moll , Rob Herring , Samuel Ortiz , "Support Opensource" , "Opensource [Adam Ward]" Subject: RE: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver Thread-Topic: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver Thread-Index: AQHQnrbir4R2W5vXa0mQH4l/7VfNGZ2eIcGAgARQsaA= Date: Mon, 8 Jun 2015 11:38:47 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B22F122@SW-EX-MBX02.diasemi.com> References: <20150605174931.GH26708@dtor-ws> In-Reply-To: <20150605174931.GH26708@dtor-ws> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1587 Lines: 52 On 05 June 2015 18:50 Dmitry Torokhov wrote: > Subject: Re: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver > On Thu, Jun 04, 2015 at 12:02:32PM +0100, S Twiss wrote: > > From: Steve Twiss > > > > Add OnKey driver support for DA9063 > > > > Signed-off-by: Steve Twiss > > > > --- > > The changes made in PATCH V3 have been taken from the DA9062 OnKey review > > thread. Please see https://lkml.org/lkml/2015/4/29/406 for more information > > on this. > > > > Version History > > > > Changes in V4 > > - No change, just a resend. > > Sorry for the delay. > > I took the liberty of rearranging the code a bit and converting it to > devm* fully, does the version below still work for you? > Hi Dmitry, No problem. Thank you for getting back to me and for taking the time to work through this code. Everything looks fine for me thank you. Tested-by: Steve Twiss I see now: in future I will make use of the devm_add_action() and use the devm* properly & your changes have simplified the error handling and negated the need for a .remove function. The devm release cleans up in reverse -- preserving the free_irq() and cancel_delayed_work_sync() ordering ... Regards, Steve. CC: Adam Ward [...] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/