Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752414AbbFHLxl (ORCPT ); Mon, 8 Jun 2015 07:53:41 -0400 Received: from www262.sakura.ne.jp ([202.181.97.72]:11537 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbbFHLxd (ORCPT ); Mon, 8 Jun 2015 07:53:33 -0400 To: mhocko@suse.cz Cc: rientjes@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] oom: always panic on OOM when panic_on_oom is configured From: Tetsuo Handa References: <1433159948-9912-1-git-send-email-mhocko@suse.cz> <20150605111302.GB26113@dhcp22.suse.cz> <201506061551.BHH48489.QHFOMtFLSOFOJV@I-love.SAKURA.ne.jp> <20150608082137.GD1380@dhcp22.suse.cz> In-Reply-To: <20150608082137.GD1380@dhcp22.suse.cz> Message-Id: <201506082053.IIF18706.JFFFHOQtMLOSVO@I-love.SAKURA.ne.jp> X-Mailer: Winbiff [Version 2.51 PL2] X-Accept-Language: ja,en,zh Date: Mon, 8 Jun 2015 20:53:18 +0900 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1232 Lines: 25 Michal Hocko wrote: > On Sat 06-06-15 15:51:35, Tetsuo Handa wrote: > > For me, !__GFP_FS allocations not calling out_of_memory() _forever_ is a > > violation of the user policy. > > Yes, the current behavior of GFP_NOFS is highly suboptimal, but this has > _nothing_ what so ever to do with this patch and panic_on_oom handling. > The former one is the page allocator proper while we are in the OOM > killer layer here. > > This is not the first time you have done that. Please stop it. It makes > a complete mess of the original discussions. My specific area of expertise in Linux kernel is security/tomoyo/ directory. What I could contribute with other areas is to pay attention to potential possibilities. But I'm such outsider about other areas that I can't differentiate the page allocator proper from the OOM killer layer. Excuse me for focusing on the wrong issue, but I will likely unconsciously make the same mistake again. Please ignore or point out when I made mistakes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/