Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753127AbbFHPhu (ORCPT ); Mon, 8 Jun 2015 11:37:50 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39434 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbbFHPhm (ORCPT ); Mon, 8 Jun 2015 11:37:42 -0400 Date: Mon, 8 Jun 2015 17:37:40 +0200 From: Michal Hocko To: "Theodore Ts'o" Cc: linux-ext4@vger.kernel.org, David Rientjes , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH -resend] jbd2: revert must-not-fail allocation loops back to GFP_NOFAIL Message-ID: <20150608153740.GC1390@dhcp22.suse.cz> References: <1433770124-19614-1-git-send-email-mhocko@suse.cz> <20150608145432.GB19168@thunk.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150608145432.GB19168@thunk.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1281 Lines: 29 On Mon 08-06-15 10:54:32, Theodore Ts'o wrote: > On Mon, Jun 08, 2015 at 03:28:44PM +0200, Michal Hocko wrote: > > This basically reverts 47def82672b3 (jbd2: Remove __GFP_NOFAIL from jbd2 > > layer). The deprecation of __GFP_NOFAIL was a bad choice because it led > > to open coding the endless loop around the allocator rather than > > removing the dependency on the non failing allocation. So the > > deprecation was a clear failure and the reality tells us that > > __GFP_NOFAIL is not even close to go away. > > > > It is still true that __GFP_NOFAIL allocations are generally discouraged > > and new uses should be evaluated and an alternative (pre-allocations or > > reservations) should be considered but it doesn't make any sense to lie > > the allocator about the requirements. Allocator can take steps to help > > making a progress if it knows the requirements. > > > > Signed-off-by: Michal Hocko > > Acked-by: David Rientjes > > Applied, thanks. Thanks! -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/