Message-ID: <DUB128-W403BFD8BDDC8C67AAC8029CBF0@phx.gbl>
From: David Binderman <dcb314@hotmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: "jason@lakedaemon.net" <jason@lakedaemon.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: linux-4.1-rc7/drivers/irqchip/irq-renesas-intc-irqpin.c:418:
 array index used before limits check ?
Date: Mon, 8 Jun 2015 16:40:46 +0000
Importance: Normal
In-Reply-To: <alpine.DEB.2.11.1506081523510.4133@nanos>
References: <DUB128-W477041E0A23148D280BEE89CBF0@phx.gbl>,<alpine.DEB.2.11.1506081508450.4133@nanos>
 <DUB128-W618D35E0256A8A879EAAE09CBF0@phx.gbl>,<alpine.DEB.2.11.1506081523510.4133@nanos>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1029
Lines: 30

Hello there Thomas,

----------------------------------------
>> I can't think of a situation where, if an array index needs checking, then
>> it should be checked *after* use.
>
> It does not check the array index. Read the complete code:
>
> for (k = 0; k < INTC_IRQPIN_REG_NR; k++) {
> io[k] = platform_get_resource(pdev, IORESOURCE_MEM, k);
> if (!io[k] && k < INTC_IRQPIN_REG_NR_MANDATORY) {
>
> The array bound is INTC_IRQPIN_REG_NR and the check about which that
> tool complains has nothing to do with array bounds. Completely valid
> code.

After a deeper look at the code, agreed. False positive by the tool.

I also checked the rest of the /irqchip/ directory for other messages by
the tool and couldn't see anything else suspicious.

Regards

David Binderman

 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/