Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753440AbbFHSHS (ORCPT ); Mon, 8 Jun 2015 14:07:18 -0400 Received: from h1446028.stratoserver.net ([85.214.92.142]:46158 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751896AbbFHSHL (ORCPT ); Mon, 8 Jun 2015 14:07:11 -0400 Message-ID: <5575D9C4.50204@ahsoftware.de> Date: Mon, 08 Jun 2015 20:07:00 +0200 From: Alexander Holler User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ingo Molnar CC: Richard Weinberger , Linus Torvalds , Tejun Heo , Louis Langholtz , Linux Kernel Mailing List , Trivial patch monkey , Rusty Russell , Andrew Morton , Peter Zijlstra , Thomas Gleixner , Greg Kroah-Hartman Subject: Re: [PATCH] debug: Deprecate BUG_ON() use in new code, introduce CRASH_ON() References: <1433721270-9182-1-git-send-email-lou_langholtz@me.com> <20150608000007.GA3543@mtj.duckdns.org> <20150608071215.GA369@gmail.com> <557546E6.5030304@ahsoftware.de> <5575558E.5070706@ahsoftware.de> <20150608090509.GA19160@gmail.com> <55755D6F.3030201@ahsoftware.de> <20150608112702.GA20511@gmail.com> In-Reply-To: <20150608112702.GA20511@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1415 Lines: 31 Am 08.06.2015 um 13:27 schrieb Ingo Molnar: > > * Alexander Holler wrote: > >>> I am pretty certain that Greg would have applied such a patch in an eye blink. >> >> As you've said it, *probably*. But such a simple exit path as you're proposing >> doesn't always exist. [...] > > As I said it's case by case. I discussed your example (which was a deficient patch > for multiple reasons) but we'd be wasting everyone's time by discussion > hypothethical situations. Sure it was a deficient patch, but still better than what existed for a year long in the kernel and which leaded to a reset of a system sometime after a wireless remote connected device was turned off. And it showed exactly where the problem existed. Maybe I should mention that almost a year after I've posted that patch, people still stumbled over the problem (and likely had the same hard time to find the reason for a sudden reboot without any warning). I just want to make clear that a brutforce slogan like BUG_ON is bad is bad, especially as there are many people which just might repeat that slogan without thinking about what they are repeating. Alexander Holler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/