Message-ID: <1433795774.2477.64.camel@freescale.com>
Subject: Re: [PATCH v2] powerpc/cache: add cache flush operation for various
 e500
From: Scott Wood <scottwood@freescale.com>
To: <Yuantian.Tang@freescale.com>
CC: <b07421@freescale.com>, <linuxppc-dev@lists.ozlabs.org>,
        <linux-kernel@vger.kernel.org>,
        Chenhui Zhao <chenhui.zhao@freescale.com>,
        Tang Yuantian <Yuantian.Tang@feescale.com>
Date: Mon, 8 Jun 2015 15:36:14 -0500
In-Reply-To: <1433757985-11653-1-git-send-email-Yuantian.Tang@freescale.com>
References: <1433757985-11653-1-git-send-email-Yuantian.Tang@freescale.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2015 20:36:21.4943
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1479
X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1448;2:K6fY38TGGyivUWxN27a8IGG6jR3HGLmYnC04HpZFgCiN0GCi1ZUIRkTqDdiihQIu;2:UkWUEbkoQ+9ZqCut74inKfgj4geE9D3M39FNbknUBcd+umecpte01Sj2ZXpXCa+Qlbn9KHrLkXFP+YU4aoScOV2GJzmlDljHIR9+7OfoxXTiop/sGGCQu0MyusKuWcUlwSd7u9pWkRGfxZtavJI0WQ==;9:hCR0LCSveuwXhu0MzlxrkSyItcReKavFr4EjOzzsVoGsnDR6A2P9ebCz3PWdjPWoSwfiQZn1V0WxOTI8lL6dSo4ZXetvRMm6uVs+SHRwDI6E/BW49AFo7Tl5Zkll7+Je6n65VSKPVzbpJSfs8nwAZQ==
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1723
Lines: 55

On Mon, 2015-06-08 at 18:06 +0800, Yuantian.Tang@freescale.com wrote:
> +
> +_GLOBAL(flush_caches_e500v2)
> +     mflr r0
> +     bl      flush_dcache_L1
> +     mtlr r0
> +     blr
> +
> +_GLOBAL(flush_caches_e500mc)
> +_GLOBAL(flush_caches_e5500)
> +     mflr r0
> +     bl      flush_dcache_L1
> +     bl      flush_backside_L2_cache
> +     mtlr r0
> +     blr

s/flush_caches/cpu_down_flush/g


> +
> +/* L1 Data Cache of e6500 contains no modified data, no flush is 
> required */
> +_GLOBAL(flush_caches_e6500)
> +     blr
> diff --git a/arch/powerpc/kernel/cputable.c 
> b/arch/powerpc/kernel/cputable.c
> index 60262fd..ed388c7 100644
> --- a/arch/powerpc/kernel/cputable.c
> +++ b/arch/powerpc/kernel/cputable.c
> @@ -2021,6 +2021,7 @@ static struct cpu_spec __initdata cpu_specs[] =
> {
>               .cpu_setup              = __setup_cpu_e500v2,
>               .machine_check          = machine_check_e500,
>               .platform               = "ppc8548",
> +             .cpu_down_flush = flush_caches_e500v2,
>       },
>  #else
>       {       /* e500mc */
> @@ -2040,6 +2041,7 @@ static struct cpu_spec __initdata cpu_specs[] =
> {
>               .cpu_setup              = __setup_cpu_e500mc,
>               .machine_check          = machine_check_e500mc,
>               .platform               = "ppce500mc",
> +             .cpu_down_flush = flush_caches_e500mc,
>       },

Please keep whitespace consistent with the rest of the structure.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/