Date: Mon, 8 Jun 2015 13:57:03 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
        linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] debugfs: support read-only and write-only bool types
Message-ID: <20150608205703.GC11211@kroah.com>
References: <1433514886-11884-1-git-send-email-rf@opensource.wolfsonmicro.com>
 <1433514886-11884-2-git-send-email-rf@opensource.wolfsonmicro.com>
 <20150605164255.GV14071@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150605164255.GV14071@sirena.org.uk>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 781
Lines: 21

On Fri, Jun 05, 2015 at 05:42:55PM +0100, Mark Brown wrote:
> On Fri, Jun 05, 2015 at 03:34:45PM +0100, Richard Fitzgerald wrote:
> 
> > +static ssize_t debugs_read_wo_file(struct file *file, char __user *buf,
> > +				   size_t count, loff_t *ppos)
> > +{
> > +	return -EACCES;
> > +}
> 
> Perhaps I'm missing something but shouldn't we be able to just omit
> empty functions like this (this seems to be what the other ro/wo debugfs
> defintions do otherwise these would already be there and it's what I'd
> expect)?


Yes you should.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/