Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753494AbbFHVtp (ORCPT ); Mon, 8 Jun 2015 17:49:45 -0400 Received: from mga11.intel.com ([192.55.52.93]:25380 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbbFHVth (ORCPT ); Mon, 8 Jun 2015 17:49:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,575,1427785200"; d="scan'208";a="584329371" Date: Mon, 8 Jun 2015 23:49:23 +0200 From: Samuel Ortiz To: Joe Perches Cc: Lauro Ramos Venancio , Aloisio Almeida Jr , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel Subject: Re: [PATCH] NFC: nci: hci: Fix releasing uninitialized skbs Message-ID: <20150608214923.GH5089@ribalta.mp.intel.com> References: <1433119485.2984.36.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433119485.2984.36.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 24 Hi Joe, On Sun, May 31, 2015 at 05:44:45PM -0700, Joe Perches wrote: > Several of these goto exit; uses should be direct returns > as skb is not yet initialized by nci_hci_get_param(). > > Miscellanea: > > o Use !memcmp instead of memcmp() == 0 > o Remove unnecessary goto from if () {... goto exit;} else {...} exit: > > Signed-off-by: Joe Perches > --- > net/nfc/nci/hci.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) Applied to nfc-next, thanks. Cheers, Samuel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/