Message-id: <55762A4E.5090208@samsung.com>
Date: Tue, 09 Jun 2015 08:50:38 +0900
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.7.0
MIME-version: 1.0
To: Anand Moon <linux.amoon@gmail.com>, Russell King <linux@arm.linux.org.uk>,
        Kukjin Kim <kgene@kernel.org>,
        Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
        Lukasz Majewski <l.majewski@samsung.com>,
        Andreas Faerber <afaerber@suse.de>,
        Sachin Kamat <sachin.kamat@samsung.com>,
        Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/2] ARM: exynos_defconfig: Enable
 CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3
References: <1433696621-4763-1-git-send-email-linux.amoon@gmail.com>
In-reply-to: <1433696621-4763-1-git-send-email-linux.amoon@gmail.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1267
Lines: 30

On 08.06.2015 02:03, Anand Moon wrote:
> Enable CONFIG_SND_SOC_ODROIDX2 and CONFIG_SND_SIMPLE_CARD to enable
> sound on Odroid-XU3 board.
> 
> Below is the output of boot log.
> [    6.021550] max98090 5-0010: MAX98090 REVID=0x43
> [    6.025506] random: nonblocking pool is initialized
> [    6.047297] asoc-simple-card sound: HiFi <-> 3830000.i2s mapping ok
> [    6.068392] s5m-rtc s2mps14-rtc: setting system clock to 2015-06-07 12:51:06 UTC (1433681466)
> [    6.123650] ALSA device list:
> [    6.135203]   #0: Odroid-XU3

Answering the question "why" and "what is device" would be sufficient.
You answered the first question ("enable sound") so you can just add
second part - using the max98090 audio codec.

This whole dmesg does not bring any benefits here, especially the
irrelevant items (like random or RTC). Could you trim the commit message?

Beside of that it looks fine however you marked this as "v2":
1. I cannot find v1 on Google. The title was the same?
2. Where is changelog?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/