Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932361AbbFIAeA (ORCPT ); Mon, 8 Jun 2015 20:34:00 -0400 Received: from mga09.intel.com ([134.134.136.24]:45878 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932135AbbFIAdw convert rfc822-to-8bit (ORCPT ); Mon, 8 Jun 2015 20:33:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,576,1427785200"; d="scan'208";a="584398269" From: "Dilger, Andreas" To: Dan Carpenter , James Simmons CC: "devel@driverdev.osuosl.org" , "Greg Kroah-Hartman" , Linux Kernel Mailing List , "Drokin, Oleg" , "lustre-devel@lists.lustre.org" Subject: Re: [lustre-devel] [PATCH v3 5/8] staging:lustre: separate kernel and user land defines in the LNet headers Thread-Topic: [lustre-devel] [PATCH v3 5/8] staging:lustre: separate kernel and user land defines in the LNet headers Thread-Index: AQHQn256m/2VIUeBsUmkBtVsSd6uL52jQ4uA Date: Tue, 9 Jun 2015 00:33:50 +0000 Message-ID: References: <1433364207-14307-1-git-send-email-jsimmons@infradead.org> <1433364207-14307-6-git-send-email-jsimmons@infradead.org> <20150605090226.GM28762@mwanda> In-Reply-To: <20150605090226.GM28762@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.76.247] Content-Type: text/plain; charset="us-ascii" Content-ID: <378CD8984DB390498A19B2696EEF2CBC@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1710 Lines: 45 On 2015/06/05, 3:02 AM, "Dan Carpenter" wrote: >On Wed, Jun 03, 2015 at 04:43:24PM -0400, James Simmons wrote: >> Currently the lnet headers used by user land contain various internal >> LNet structures that are only used by kernel space. Move the user land >> structures to headers used by user land. The kernel structures are >> relocated to headers that are never exposed to user land. >> >> Signed-off-by: James Simmons >> --- >> diff --git a/drivers/staging/lustre/lnet/lnet/acceptor.c >>b/drivers/staging/lustre/lnet/lnet/acceptor.c >> index 1dc7c8a..4928f5c 100644 >> --- a/drivers/staging/lustre/lnet/lnet/acceptor.c >> +++ b/drivers/staging/lustre/lnet/lnet/acceptor.c >> @@ -243,8 +243,6 @@ lnet_accept(struct socket *sock, __u32 magic) >> >> if (magic == le32_to_cpu(LNET_PROTO_TCP_MAGIC)) >> str = "'old' socknal/tcpnal"; >> - else if (lnet_accept_magic(magic, LNET_PROTO_RA_MAGIC)) >> - str = "'old' ranal"; >> else >> str = "unrecognised"; >> > >Presumably this was done intentionally. We deleted LNET_PROTO_RA_MAGIC. >The changelog was not very clear why. The "Rapid Array" network interface is an obsolete network once used by Cray hardware but hasn't been supported for about 10 years and was (mostly) deleted from the tree already. This was just a left-over I guess. Cheers, Andreas -- Andreas Dilger Lustre Software Architect Intel High Performance Data Division -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/