Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932738AbbFIAke (ORCPT ); Mon, 8 Jun 2015 20:40:34 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:33139 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752981AbbFIAk1 (ORCPT ); Mon, 8 Jun 2015 20:40:27 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 191.101.57.28 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: <78e2b6956a4a88950c98e5d5ff89f723> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <557635EC.7040402@rock-chips.com> Date: Tue, 09 Jun 2015 08:40:12 +0800 From: Caesar Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Russell King - ARM Linux CC: Heiko Stuebner , dianders@chromium.org, Dmitry Torokhov , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/3] ARM: rockchip: ensure CPU to enter WFI/WFE state References: <1433747496-7642-1-git-send-email-wxt@rock-chips.com> <1433747496-7642-3-git-send-email-wxt@rock-chips.com> <20150608092852.GW7557@n2100.arm.linux.org.uk> In-Reply-To: <20150608092852.GW7557@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1262 Lines: 45 在 2015年06月08日 17:28, Russell King - ARM Linux 写道: > On Mon, Jun 08, 2015 at 03:11:35PM +0800, Caesar Wang wrote: >> diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c >> index bd40852..5bc2a89 100644 >> --- a/arch/arm/mach-rockchip/platsmp.c >> +++ b/arch/arm/mach-rockchip/platsmp.c >> @@ -321,6 +321,9 @@ static void __init rockchip_smp_prepare_cpus(unsigned int max_cpus) >> #ifdef CONFIG_HOTPLUG_CPU >> static int rockchip_cpu_kill(unsigned int cpu) >> { >> + /* ensure CPU can enter the WFI/WFE state */ > I would like to see a better comment here, describing what the problem > is. Maybe something like this: > > /* > * We need a delay here to ensure that the dying CPU can finish > * executing v7_coherency_exit() and reach the WFI/WFE state > * prior to having the power domain disabled. > */ > > Thanks. OK, Thanks! >> + mdelay(1); >> + >> pmu_set_power_domain(0 + cpu, false); >> return 1; >> } >> -- >> 1.9.1 >> -- Thanks, - Caesar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/