Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753605AbbFIDYW (ORCPT ); Mon, 8 Jun 2015 23:24:22 -0400 Received: from mga01.intel.com ([192.55.52.88]:30185 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511AbbFIDYO (ORCPT ); Mon, 8 Jun 2015 23:24:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,577,1427785200"; d="scan'208";a="707664181" Message-ID: <55765B68.1010300@linux.intel.com> Date: Tue, 09 Jun 2015 11:20:08 +0800 From: Xiao Guangrong User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org CC: rkrcmar@redhat.com, bdas@redhat.com Subject: Re: [PATCH v2 08/13] KVM: implement multiple address spaces References: <1432746314-50196-1-git-send-email-pbonzini@redhat.com> <1432746314-50196-9-git-send-email-pbonzini@redhat.com> In-Reply-To: <1432746314-50196-9-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 910 Lines: 31 On 05/28/2015 01:05 AM, Paolo Bonzini wrote: > /* > @@ -772,6 +776,7 @@ int __kvm_set_memory_region(struct kvm *kvm, > struct kvm_memory_slot *slot; > struct kvm_memory_slot old, new; > struct kvm_memslots *slots = NULL, *old_memslots; > + int as_id, id; > enum kvm_mr_change change; > > r = check_memory_region_flags(mem); > @@ -779,24 +784,27 @@ int __kvm_set_memory_region(struct kvm *kvm, > goto out; > > r = -EINVAL; > + as_id = mem->slot >> 16; > + id = mem->slot & 65535; > + A minor comment, Could you put these decoding into a separate function? Nice idea indeed. Reviewed-by: Xiao Guangrong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/