Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932346AbbFIDcW (ORCPT ); Mon, 8 Jun 2015 23:32:22 -0400 Received: from mga09.intel.com ([134.134.136.24]:3041 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753264AbbFIDcI (ORCPT ); Mon, 8 Jun 2015 23:32:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,577,1427785200"; d="scan'208";a="723565798" Message-ID: <55765D43.8090302@linux.intel.com> Date: Tue, 09 Jun 2015 11:28:03 +0800 From: Xiao Guangrong User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org CC: rkrcmar@redhat.com, bdas@redhat.com Subject: Re: [PATCH v2 09/13] KVM: x86: pass kvm_mmu_page to gfn_to_rmap References: <1432746314-50196-1-git-send-email-pbonzini@redhat.com> <1432746314-50196-10-git-send-email-pbonzini@redhat.com> In-Reply-To: <1432746314-50196-10-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 29 On 05/28/2015 01:05 AM, Paolo Bonzini wrote: > This is always available (with one exception in the auditing code). > Later we will also use the role to look up the right memslots array. > return; > @@ -191,11 +191,15 @@ static void audit_write_protection(struct kvm *kvm, struct kvm_mmu_page *sp) > unsigned long *rmapp; > u64 *sptep; > struct rmap_iterator iter; > + struct kvm_memslots *slots; > + struct kvm_memory_slot *slot; > > if (sp->role.direct || sp->unsync || sp->role.invalid) > return; > > - rmapp = gfn_to_rmap(kvm, sp->gfn, PT_PAGE_TABLE_LEVEL); > + slots = kvm_memslots(kvm); > + slot = __gfn_to_memslot(slots, sp->gfn); > + rmapp = __gfn_to_rmap(sp->gfn, PT_PAGE_TABLE_LEVEL, slot); > Why @sp is not available here? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/