Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753284AbbFIENO (ORCPT ); Tue, 9 Jun 2015 00:13:14 -0400 Received: from mail-am1on0141.outbound.protection.outlook.com ([157.56.112.141]:55097 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751228AbbFIEND (ORCPT ); Tue, 9 Jun 2015 00:13:03 -0400 Authentication-Results: lists.infradead.org; dkim=none (message not signed) header.d=none; Message-ID: <557667AC.3030506@toradex.com> Date: Tue, 9 Jun 2015 09:42:28 +0530 From: Bhuvanchandra DV User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Russell King - ARM Linux CC: , , , , , , , , , , Subject: Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl References: <1433136067-20644-1-git-send-email-bhuvanchandra.dv@toradex.com> <1433136067-20644-3-git-send-email-bhuvanchandra.dv@toradex.com> <20150608091244.GS7557@n2100.arm.linux.org.uk> In-Reply-To: <20150608091244.GS7557@n2100.arm.linux.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [122.166.214.162] X-ClientProxiedBy: HK2PR0201CA0002.apcprd02.prod.outlook.com (25.162.206.12) To AMSPR05MB262.eurprd05.prod.outlook.com (10.242.95.19) X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AMSPR05MB262; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520003)(3002001);SRVR:AMSPR05MB262;BCL:0;PCL:0;RULEID:;SRVR:AMSPR05MB262; X-Forefront-PRVS: 06022AA85F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(6049001)(51704005)(377454003)(479174004)(54356999)(87266999)(65816999)(50986999)(76176999)(4001350100001)(65806001)(80316001)(65956001)(66066001)(87976001)(47776003)(33656002)(36756003)(92566002)(189998001)(122386002)(77156002)(62966003)(40100003)(64126003)(83506001)(2950100001)(110136002)(5001960100002)(86362001)(46102003)(77096005)(99136001)(50466002)(42186005);DIR:OUT;SFP:1102;SCL:1;SRVR:AMSPR05MB262;H:[10.18.0.154];FPR:;SPF:None;MLV:sfv;LANG:en; X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2015 04:12:55.2213 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR05MB262 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 857 Lines: 24 On 06/08/2015 02:42 PM, Russell King - ARM Linux wrote: > On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote: >> + /* >> + * CTS/RTS can _only_ be handled >> + * automatically by the hardware. >> + */ > > That's really not acceptable. You need to do something here so that you > can _force_ RTS to be deasserted when the kernel buffers fill up - be > that by stopping reading characters and letting the FIFO fill up or > something of that ilk. Agreed, will fix this. > > Ignoring the rest of the flow control system in the kernel is not really > acceptable. > Best regards, Bhuvan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/