Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753188AbbFIE4u (ORCPT ); Tue, 9 Jun 2015 00:56:50 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33774 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750814AbbFIE4k (ORCPT ); Tue, 9 Jun 2015 00:56:40 -0400 Date: Tue, 9 Jun 2015 13:56:32 +0900 From: Tejun Heo To: Aleksa Sarai Cc: lizefan@huawei.com, mingo@redhat.com, peterz@infradead.org, richard@nod.at, fweisbec@gmail.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v13 5/5] cgroup: implement the PIDs subsystem Message-ID: <20150609045632.GR21465@mtj.duckdns.org> References: <1433547736-11707-1-git-send-email-cyphar@cyphar.com> <1433548938-32560-5-git-send-email-cyphar@cyphar.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433548938-32560-5-git-send-email-cyphar@cyphar.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1544 Lines: 50 Hello, Aleksa. On Sat, Jun 06, 2015 at 10:02:18AM +1000, Aleksa Sarai wrote: ... > +/* > + * Lockless hierarchical accounting (with enforceable limits) derived from > + * mm/page_counter.c. Original copyright notice from page_counter code: > + * > + * ------------------------------------------------- > + * Lockless hierarchical page accounting & limiting > + * Copyright (C) 2014 Red Hat, Inc., Johannes Weiner > + * ------------------------------------------------- > + */ I don't think we need the above copyright notice. ... > +struct cgroup_subsys pids_cgrp_subsys = { > + .css_alloc = pids_css_alloc, > + .css_free = pids_css_free, > + .attach = pids_attach, > + .can_attach = pids_can_attach, > + .cancel_attach = pids_cancel_attach, > + .can_fork = pids_can_fork, > + .cancel_fork = pids_cancel_fork, > + .fork = pids_fork, > + .exit = pids_exit, > + .legacy_cftypes = files, Please also init dfl_cftypes the same way too. Also, can you please rename files to pids_files? > + .early_init = 0, And the above can be dropped. Other than the above minor points, everything looks good to me but I think we're a bit too close to the merge window to put this in now. Once you update patch 4 and 5 according to the review, I'll apply them after the next rc1 drops. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/