Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932227AbbFIGLN (ORCPT ); Tue, 9 Jun 2015 02:11:13 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:46430 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752382AbbFIGLB (ORCPT ); Tue, 9 Jun 2015 02:11:01 -0400 X-IronPort-AV: E=Sophos;i="5.13,577,1427752800"; d="scan'208";a="164056993" Date: Tue, 9 Jun 2015 08:10:58 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Michal Simek cc: Paul Bolle , Kedareswara rao Appana , dan.j.williams@intel.com, vinod.koul@intel.com, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, appanad@xilinx.com, punnaia@xilinx.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Srikanth Thokala , Greg Kroah-Hartman , Julia Lawall Subject: Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support In-Reply-To: <557681A7.7080202@monstr.eu> Message-ID: References: <1432228035-6569-1-git-send-email-appanad@xilinx.com> <1432290653.27695.97.camel@x220> <557681A7.7080202@monstr.eu> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1511 Lines: 39 On Tue, 9 Jun 2015, Michal Simek wrote: > Hi Paul, > > On 05/22/2015 12:30 PM, Paul Bolle wrote: > > Again, just a nit: a license mismatch. > > > > On Thu, 2015-05-21 at 22:37 +0530, Kedareswara rao Appana wrote: > > > >> + * This program is free software: you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License as published by > >> + * the Free Software Foundation, either version 2 of the License, or > >> + * (at your option) any later version. > > > >> +MODULE_LICENSE("GPL v2"); > > > > As I said in the message I sent a short while ago: here too I think that > > either the comment at the top of this file or the ident used in the > > MODULE_LICENSE() macro needs to change. > > This is not just the problem with this driver but with others too. > Have you sent any patch to add GPL v2+ to license.h? > > Also sort of checking for this will be great. Julia? If this requires checking the contents of comment, Coccinelle currently can't help with that. Perhaps an idea would be to just do a grep on the file. So if I find MODULE_LICENSE("GPL v2") and then grepping for "either vresion 2" gives success, then there is a problem? It's obviously not foolproof, but perhaps it could be helpful. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/