Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932577AbbFIGvO (ORCPT ); Tue, 9 Jun 2015 02:51:14 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:36209 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752339AbbFIGvG (ORCPT ); Tue, 9 Jun 2015 02:51:06 -0400 Date: Tue, 9 Jun 2015 07:51:01 +0100 From: Lee Jones To: Dmitry Torokhov Cc: S Twiss , Samuel Ortiz , DT , David Dajun Chen , INPUT , Ian Campbell , Kumar Gala , LKML , Mark Rutland , Pawel Moll , Rob Herring , Support Opensource Subject: Re: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver Message-ID: <20150609065101.GA2982@x1> References: <20150608232507.GB420@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150608232507.GB420@dtor-ws> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2158 Lines: 59 On Mon, 08 Jun 2015, Dmitry Torokhov wrote: > On Tue, May 19, 2015 at 11:32:45AM +0100, S Twiss wrote: > > From: Steve Twiss > > > > Add MFD support for the DA9063 OnKey driver > > > > The function da9063_clear_fault_log() is added to mitigate the case of a > > hardware power-cut after a long-long OnKey press. Although there is no > > software intervention in this case (by definition) such a shutdown would > > cause persistent information within the DA9063 FAULT_LOG that would be > > available during the next device restart. > > > > Clearance of this persistent register must be completed after such a > > hardware power-cut operation has happened so that the FAULT_LOG does not > > continue with previous values. The clearance function has been added here > > in the kernel driver because wiping the fault-log cannot be counted on > > outside the Linux kernel. > > > > Acked-by: Lee Jones > > > > Signed-off-by: Steve Twiss > > ... > > > diff --git a/include/linux/mfd/da9063/pdata.h b/include/linux/mfd/da9063/pdata.h > > index 95c8742..612383b 100644 > > --- a/include/linux/mfd/da9063/pdata.h > > +++ b/include/linux/mfd/da9063/pdata.h > > @@ -103,6 +103,7 @@ struct da9063; > > struct da9063_pdata { > > int (*init)(struct da9063 *da9063); > > int irq_base; > > + bool key_power; > > unsigned flags; > > struct da9063_regulators_pdata *regulators_pdata; > > struct led_platform_data *leds_pdata; > > I need this bit of pdata to merge the OnKey driver... Lee, any chance > you could drop it from the patch in your tree? Consider it done. > Alternatively, can you pick the OnKey driver (the latest version is > below)? > > Thanks. > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/