Message-ID: <55769058.3030406@jp.fujitsu.com>
Date: Tue, 09 Jun 2015 16:06:00 +0900
From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Xishi Qiu <qiuxishi@huawei.com>, Andrew Morton <akpm@linux-foundation.org>,
        nao.horiguchi@gmail.com, Yinghai Lu <yinghai@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
        mingo@elte.hu, Xiexiuqi <xiexiuqi@huawei.com>,
        Hanjun Guo <guohanjun@huawei.com>, "Luck, Tony" <tony.luck@intel.com>
CC: Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 08/12] mm: use mirrorable to switch allocate mirrored
 memory
References: <55704A7E.5030507@huawei.com> <55704C79.5060608@huawei.com>
In-Reply-To: <55704C79.5060608@huawei.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2162
Lines: 72

On 2015/06/04 22:02, Xishi Qiu wrote:
> Add a new interface in path /proc/sys/vm/mirrorable. When set to 1, it means
> we should allocate mirrored memory for both user and kernel processes.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>

I can't see why do we need this switch. If this is set, all GFP_HIGHUSER will use
mirrored memory ?

Or will you add special MMAP/madvise flag to use mirrored memory ?

Thanks,
-Kame

> ---
>   include/linux/mmzone.h | 1 +
>   kernel/sysctl.c        | 9 +++++++++
>   mm/page_alloc.c        | 1 +
>   3 files changed, 11 insertions(+)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index f82e3ae..20888dd 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -85,6 +85,7 @@ struct mirror_info {
>   };
>
>   extern struct mirror_info mirror_info;
> +extern int sysctl_mirrorable;
>   #  define is_migrate_mirror(migratetype) unlikely((migratetype) == MIGRATE_MIRROR)
>   #else
>   #  define is_migrate_mirror(migratetype) false
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 2082b1a..dc2625e 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -1514,6 +1514,15 @@ static struct ctl_table vm_table[] = {
>   		.extra2		= &one,
>   	},
>   #endif
> +#ifdef CONFIG_MEMORY_MIRROR
> +	{
> +		.procname	= "mirrorable",
> +		.data		= &sysctl_mirrorable,
> +		.maxlen		= sizeof(sysctl_mirrorable),
> +		.mode		= 0644,
> +		.proc_handler	= proc_dointvec_minmax,
> +	},
> +#endif
>   	{
>   		.procname	= "user_reserve_kbytes",
>   		.data		= &sysctl_user_reserve_kbytes,
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 249a8f6..63b90ca 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -212,6 +212,7 @@ int user_min_free_kbytes = -1;
>
>   #ifdef CONFIG_MEMORY_MIRROR
>   struct mirror_info mirror_info;
> +int sysctl_mirrorable = 0;
>   #endif
>
>   static unsigned long __meminitdata nr_kernel_pages;
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/