Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753419AbbFIHWD (ORCPT ); Tue, 9 Jun 2015 03:22:03 -0400 Received: from mail1.bemta14.messagelabs.com ([193.109.254.109]:20166 "EHLO mail1.bemta14.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbbFIHVx (ORCPT ); Tue, 9 Jun 2015 03:21:53 -0400 X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-13.tower-193.messagelabs.com!1433834508!23081261!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Steve Twiss]" To: Lee Jones , Dmitry Torokhov CC: Samuel Ortiz , DT , David Dajun Chen , INPUT , Ian Campbell , Kumar Gala , LKML , "Mark Rutland" , Pawel Moll , Rob Herring , Support Opensource Subject: RE: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver Thread-Topic: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver Thread-Index: AQHQkh+AIiDgJ7oLLk27mZIkSOv+M52jT7OAgAB8lYCAABjaEA== Date: Tue, 9 Jun 2015 07:21:46 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B22F1EA@SW-EX-MBX02.diasemi.com> References: <20150608232507.GB420@dtor-ws> <20150609065101.GA2982@x1> In-Reply-To: <20150609065101.GA2982@x1> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t597M9AM026442 Content-Length: 2095 Lines: 55 On 09 June 2015 07:51 Lee Jones wrote: > On Mon, 08 Jun 2015, Dmitry Torokhov wrote: > > On Tue, May 19, 2015 at 11:32:45AM +0100, S Twiss wrote: > > > From: Steve Twiss > > > > > > Add MFD support for the DA9063 OnKey driver > > > > > > The function da9063_clear_fault_log() is added to mitigate the case of a > > > hardware power-cut after a long-long OnKey press. Although there is no > > > software intervention in this case (by definition) such a shutdown would > > > cause persistent information within the DA9063 FAULT_LOG that would be > > > available during the next device restart. > > > > > > Clearance of this persistent register must be completed after such a > > > hardware power-cut operation has happened so that the FAULT_LOG does not > > > continue with previous values. The clearance function has been added here > > > in the kernel driver because wiping the fault-log cannot be counted on > > > outside the Linux kernel. > > > > > > Acked-by: Lee Jones > > > > > > Signed-off-by: Steve Twiss > > > > ... > > > > > diff --git a/include/linux/mfd/da9063/pdata.h > b/include/linux/mfd/da9063/pdata.h > > > index 95c8742..612383b 100644 > > > --- a/include/linux/mfd/da9063/pdata.h > > > +++ b/include/linux/mfd/da9063/pdata.h > > > @@ -103,6 +103,7 @@ struct da9063; > > > struct da9063_pdata { > > > int (*init)(struct da9063 *da9063); > > > int irq_base; > > > + bool key_power; > > > unsigned flags; > > > struct da9063_regulators_pdata *regulators_pdata; > > > struct led_platform_data *leds_pdata; > > > > I need this bit of pdata to merge the OnKey driver... Lee, any chance > > you could drop it from the patch in your tree? > > Consider it done. > > > Alternatively, can you pick the OnKey driver (the latest version is > > below)? > > > > Thanks. > > Thank you both for your help. Regards, Steve ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?