Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932865AbbFIJRm (ORCPT ); Tue, 9 Jun 2015 05:17:42 -0400 Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:35492 "EHLO lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753557AbbFIJRd (ORCPT ); Tue, 9 Jun 2015 05:17:33 -0400 Message-ID: <1433841449.16887.58.camel@x220> Subject: Re: [PATCH 2/2] cpufreq: mediatek: Add MT8173 cpufreq driver From: Paul Bolle To: Pi-Cheng Chen Cc: Viresh Kumar , Mike Turquette , Matthias Brugger , Mark Rutland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linaro-kernel@lists.linaro.org, linux-mediatek@lists.infradead.org Date: Tue, 09 Jun 2015 11:17:29 +0200 In-Reply-To: <1433766561-1330-3-git-send-email-pi-cheng.chen@linaro.org> References: <1433766561-1330-1-git-send-email-pi-cheng.chen@linaro.org> <1433766561-1330-3-git-send-email-pi-cheng.chen@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 649 Lines: 25 On Mon, 2015-06-08 at 20:29 +0800, Pi-Cheng Chen wrote: > --- /dev/null > +++ b/drivers/cpufreq/mt8173-cpufreq.c > +#include Weren't you going to drop this include? > +module_init(mt8173_cpufreq_driver_init); For built-in code this is equivalent to, speaking from memory: device_initcall(mt8173_cpufreq_driver_init); Why don't you just use that directly? Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/