Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932904AbbFIJSP (ORCPT ); Tue, 9 Jun 2015 05:18:15 -0400 Received: from mga02.intel.com ([134.134.136.20]:43948 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753283AbbFIJSH (ORCPT ); Tue, 9 Jun 2015 05:18:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,579,1427785200"; d="scan'208";a="505368193" Date: Tue, 9 Jun 2015 12:17:57 +0300 From: Jarkko Sakkinen To: "Moore, Robert" Cc: "Zheng, Lv" , "Wysocki, Rafael J" , Len Brown , "open list:ACPI COMPONENT AR..." , "open list:ACPI COMPONENT AR..." , open list Subject: Re: [PATCH] acpi: update struct acpi_table_tpm2 Message-ID: <20150609091757.GB4968@jsakkine-mobl1> References: <1433770706-3332-1-git-send-email-jarkko.sakkinen@linux.intel.com> <94F2FBAB4432B54E8AACC7DFDE6C92E37D2F28EC@ORSMSX112.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37D2F28EC@ORSMSX112.amr.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 906 Lines: 23 On Mon, Jun 08, 2015 at 08:52:02PM +0000, Moore, Robert wrote: > It looks like there is a change to the TCPA table also. Right. I'll update that too. I strongly think that the struct acpi_tpm2_control should not be in actbl3.h. It is not defined in the TCG ACPI specification. It is defined in http://www.trustedcomputinggroup.org/resources/pc_client_platform_tpm_profile_ptp_specification FIFO control structures are internal for to the TPM subsystem and so should be CRB control structures (and we have already inside tpm_crb.c). The structure ended up there probably because it was combined with the TPM2 table in that Microsoft specification. /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/