User-Agent: K-9 Mail for Android
In-Reply-To: <20150609091932.GC4968@jsakkine-mobl1>
References: <1433349555-30868-1-git-send-email-jarkko.sakkinen@linux.intel.com> <201506082239.33639.PeterHuewe@gmx.de> <20150609091932.GC4968@jsakkine-mobl1>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 8BIT
Subject: Re: [tpmdd-devel] [PATCH v2] tpm: introduce struct tpm_buf
From: Peter Huewe <peterhuewe@gmx.de>
Date: Tue, 09 Jun 2015 12:32:57 +0200
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
CC: "moderated list:TPM DEVICE DRIVER" 
	<tpmdd-devel@lists.sourceforge.net>,
        safford@us.ibm.com, open list <linux-kernel@vger.kernel.org>
Message-ID: <1C403FBE-76FF-425C-8627-5956838CD560@gmx.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 748
Lines: 27


Hi

>> > +static inline void tpm_buf_store(struct tpm_buf *buf,
>> > +				 unsigned int pos,
>> > +				 const unsigned char *data,
>> > +				 unsigned int len)
>> > +{
>> > +	BUG_ON((pos + len) > TPM_BUF_SIZE);
>> > +
>> > +	memcpy(&buf->data[pos], data, len);
>> > +}
>> 
>> Don't you have to update the ->length here?
>
>No. Store is for placing value in position, not appending to the end.
>
Then either add a length check (whether ->length is big enough) and/or call the function "update"

Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/