Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753601AbbFIKmJ (ORCPT ); Tue, 9 Jun 2015 06:42:09 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:34475 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752672AbbFIKmF (ORCPT ); Tue, 9 Jun 2015 06:42:05 -0400 Message-ID: <5576C2F5.3050806@monstr.eu> Date: Tue, 09 Jun 2015 12:41:57 +0200 From: Michal Simek Reply-To: monstr@monstr.eu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Paul Bolle , monstr@monstr.eu CC: Julia Lawall , Kedareswara rao Appana , dan.j.williams@intel.com, vinod.koul@intel.com, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, appanad@xilinx.com, punnaia@xilinx.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Srikanth Thokala , Greg Kroah-Hartman , Joe Perches , Fengguang Wu Subject: Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support References: <1432228035-6569-1-git-send-email-appanad@xilinx.com> <1432290653.27695.97.camel@x220> <557681A7.7080202@monstr.eu> <55769132.6070601@monstr.eu> <1433837720.16887.42.camel@x220> In-Reply-To: <1433837720.16887.42.camel@x220> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="j7Jnrh4VuLU6jP4DxOCXAQJmQKQDWn5ge" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3833 Lines: 109 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --j7Jnrh4VuLU6jP4DxOCXAQJmQKQDWn5ge Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/09/2015 10:15 AM, Paul Bolle wrote: > On Tue, 2015-06-09 at 09:09 +0200, Michal Simek wrote: >> On 06/09/2015 08:10 AM, Julia Lawall wrote: >>> On Tue, 9 Jun 2015, Michal Simek wrote: >>>> Also sort of checking for this will be great. Julia? >>> >>> If this requires checking the contents of comment, Coccinelle current= ly=20 >>> can't help with that. Perhaps an idea would be to just do a grep on = the=20 >>> file. So if I find MODULE_LICENSE("GPL v2") and then grepping for "e= ither=20 >>> vresion 2" gives success, then there is a problem? It's obviously no= t=20 >>> foolproof, but perhaps it could be helpful. >> >> Having some sort of checking somewhere will be great. checkpatch? >> zero-day testing system? >=20 > Mistakes I've seen made since I started checking this stuff (a few > months ago): > - typos in the license ident, say "GPLv2", "GPL V2", or "BSD": generate= s > a warning when module is loaded and taints kernel. People still get thi= s > wrong. A test in checkpatch for these typos was submitted a while ago, > but it never got added; Any reason for that? just lost or any problem ? > - not adding MODULE_LICENSE() to a module: also generates a warning whe= n > module is loaded and taints kernel. People still get this wrong; > - adding MODULE_LICENSE() to built-in only code: pointless at best, and= > annoying for reviewers ("Hey, did the submitter intend to write built-i= n > only code or modular code?"); > - using "Dual BSD/GPL" but not a trace of the BSD license blurb in > sight, while adding that blurb is one of the very few requirements this= > license actually has; > - license mismatch, say comment blurb states "GPL v2 (or later)" but > MODULE_LICENSE() ident states "GPL v2" only (or vice versa): very easy > mistake to make, happens once or twice a week. =20 What do you mean by vice versa? GPL v2 header and MODULE_LICENSE("GPL") should be fine right? >=20 > Did I miss anything in that list? I think you miss MODULE_ALIAS problems. https://lkml.org/lkml/2014/3/17/301 >=20 > I'm afraid that most of the above can only be caught reliably by > attention to detail by submitters and reviewers. That's a pity, because= > checking for that stuff is about as boring as it gets. (What does that > say about me?) yep. I have never looked at the details about these license module stuff. But definitely great to have this list - will record it and keep my eye on our xilinx drivers. BTW: Some time ago we discussed SPDX License Identifier which could simplify license checking. https://lkml.org/lkml/2014/2/21/21 Interesting also is that selftests are using just "Licensed under the GPLv2." Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform --j7Jnrh4VuLU6jP4DxOCXAQJmQKQDWn5ge Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iEYEARECAAYFAlV2wvgACgkQykllyylKDCHteACbBNDMm5rv1JaNQ2f0Aed2obTw oYUAnizjmorblhb395aj9adAuixrZxWU =7ryg -----END PGP SIGNATURE----- --j7Jnrh4VuLU6jP4DxOCXAQJmQKQDWn5ge-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/