Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933159AbbFILHi (ORCPT ); Tue, 9 Jun 2015 07:07:38 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:49375 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933127AbbFILH1 (ORCPT ); Tue, 9 Jun 2015 07:07:27 -0400 Message-ID: <5576C8E6.7070500@collabora.co.uk> Date: Tue, 09 Jun 2015 13:07:18 +0200 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Olof Johansson , Lee Jones CC: Samuel Ortiz , Doug Anderson , Bill Richardson , Simon Glass , Gwendal Grignou , Stephen Barber , Filipe Brandenburger , Todd Broch , Alexandru M Stan , Heiko Stuebner , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Gwendal Grignou Subject: Re: [PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system References: <1433405154-16273-1-git-send-email-javier.martinez@collabora.co.uk> <1433405154-16273-7-git-send-email-javier.martinez@collabora.co.uk> <20150605101730.GE7058@x1> <20150608204614.GA20574@quad.lixom.net> In-Reply-To: <20150608204614.GA20574@quad.lixom.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3734 Lines: 94 Hello Olof, On 06/08/2015 10:46 PM, Olof Johansson wrote: > On Fri, Jun 05, 2015 at 11:17:30AM +0100, Lee Jones wrote: >> On Thu, 04 Jun 2015, Javier Martinez Canillas wrote: >> >> > From: Gwendal Grignou >> > >> > Chromebooks can have more than one Embedded Controller so the >> > cros_ec device id has to be incremented for each EC registered. >> > >> > Add a new structure to represent multiple EC as different char >> > devices (e.g: /dev/cros_ec, /dev/cros_pd). It connects to >> > cros_ec_device and allows sysfs inferface for cros_pd. >> > >> > Also reduce number of allocated objects, make chromeos sysfs >> > class object a static and add refcounting to prevent object >> > deletion while command is in progress. >> > >> > Signed-off-by: Gwendal Grignou >> > Reviewed-by: Dmitry Torokhov >> > Signed-off-by: Javier Martinez Canillas >> > Tested-by: Heiko Stuebner >> > --- >> > >> > Changes since v5: >> > - Don't allow to change the device name from DT. Suggested by Lee Jones. >> > - Expand error messages in case of mfd_add_devices() failure. >> > Suggested by Lee Jones. >> > >> > Changes since v4: >> > - Use cros-ec-name DT property instead of devname. Suggested by Lee Jones. >> > - Pass PLATFORM_DEVID_AUTO directly to mfd_add_devices(). >> > Suggested by Lee Jones. >> > - Add Heiko Stuebner tested-by tag. >> > - Fix get_version by passing the cmd_offset to EC_CMD_GET_VERSION. >> > >> > Changes since v3: >> > - Add defines for the EC and PD index constants. >> > - Remove cros_ec_dev_register() and declare the mfd_cells as static structs. >> > Suggested by Lee Jones. >> > - Add a new line before the return statement in cros_ec_dev_register(). >> > Suggested by Lee Jones. >> > >> > Changes since v2: None >> > >> > Changes since v1: >> > - Squash patch that adds support to represent EC's as different >> > char devices (e.g: /dev/cros_ec, /dev/cros_pd): >> > https://chromium-review.googlesource.com/#/c/217297/ >> > Suggested by Gwendal Grignou >> > - Use cros_ec instead of cros-ec in the subject line to be consistent. >> > Suggested by Gwendal Grignou >> > --- >> > drivers/input/keyboard/cros_ec_keyb.c | 2 +- >> > drivers/mfd/cros_ec.c | 52 ++++++++++-- >> > drivers/mfd/cros_ec_i2c.c | 1 - >> > drivers/mfd/cros_ec_spi.c | 1 - >> > drivers/platform/chrome/cros_ec_dev.c | 130 ++++++++++++++++++++--------- >> > drivers/platform/chrome/cros_ec_dev.h | 7 -- >> > drivers/platform/chrome/cros_ec_lightbar.c | 75 +++++++++-------- >> > drivers/platform/chrome/cros_ec_lpc.c | 1 - >> > drivers/platform/chrome/cros_ec_sysfs.c | 48 +++++------ >> > include/linux/mfd/cros_ec.h | 44 ++++++++-- >> > 10 files changed, 234 insertions(+), 127 deletions(-) >> >> For my own reference: >> Acked-by: Lee Jones >> >> Let me know when you have all the appropriate Acks and I'll apply the >> set. > > Whole series: > > Acked-by: Olof Johansson > > I'm OK with this going through the mfd tree, since there's nothing queued up > for chrome-platform that this would conflict with. > Thanks a lot for the acks, I'll resend a v7 with your Acked-by tags and fixing a small nit Lee pointed out on patch 6/8. > > -Olof > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/