Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933170AbbFIMG1 (ORCPT ); Tue, 9 Jun 2015 08:06:27 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:32841 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932930AbbFIMGE (ORCPT ); Tue, 9 Jun 2015 08:06:04 -0400 From: Sergey Senozhatsky To: Andrew Morton Cc: Minchan Kim , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Michal Hocko , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, sergey.senozhatsky.work@gmail.com, Sergey Senozhatsky Subject: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool() Date: Tue, 9 Jun 2015 21:04:52 +0900 Message-Id: <1433851493-23685-5-git-send-email-sergey.senozhatsky@gmail.com> X-Mailer: git-send-email 2.4.3.368.g7974889 In-Reply-To: <1433851493-23685-1-git-send-email-sergey.senozhatsky@gmail.com> References: <1433851493-23685-1-git-send-email-sergey.senozhatsky@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 41 zpool_destroy_pool() does not tolerate a NULL zpool pointer argument and performs a NULL-pointer dereference. Although there is only one zpool_destroy_pool() user (as of 4.1), still update it to be coherent with the corresponding destroy() functions of the remainig pool-allocators (slab, mempool, etc.), which now allow NULL pool-pointers. For consistency, tweak zpool_destroy_pool() and NULL-check the pointer there. Proposed by Andrew Morton. Signed-off-by: Sergey Senozhatsky Reported-by: Andrew Morton LKML-reference: https://lkml.org/lkml/2015/6/8/583 --- mm/zpool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/zpool.c b/mm/zpool.c index bacdab6..2f59b90 100644 --- a/mm/zpool.c +++ b/mm/zpool.c @@ -202,6 +202,9 @@ struct zpool *zpool_create_pool(char *type, char *name, gfp_t gfp, */ void zpool_destroy_pool(struct zpool *zpool) { + if (unlikely(!zpool)) + return; + pr_info("destroying pool type %s\n", zpool->type); spin_lock(&pools_lock); -- 2.4.3.368.g7974889 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/