Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933289AbbFIMM7 (ORCPT ); Tue, 9 Jun 2015 08:12:59 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:33091 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932971AbbFIMMu (ORCPT ); Tue, 9 Jun 2015 08:12:50 -0400 Message-ID: <5576D83D.2000006@monstr.eu> Date: Tue, 09 Jun 2015 14:12:45 +0200 From: Michal Simek Reply-To: monstr@monstr.eu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Paul Bolle , monstr@monstr.eu CC: Julia Lawall , Kedareswara rao Appana , dan.j.williams@intel.com, vinod.koul@intel.com, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, appanad@xilinx.com, punnaia@xilinx.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Srikanth Thokala , Greg Kroah-Hartman , Joe Perches , Fengguang Wu Subject: Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support References: <1432228035-6569-1-git-send-email-appanad@xilinx.com> <1432290653.27695.97.camel@x220> <557681A7.7080202@monstr.eu> <55769132.6070601@monstr.eu> <1433837720.16887.42.camel@x220> <5576C2F5.3050806@monstr.eu> <1433851175.16887.83.camel@x220> In-Reply-To: <1433851175.16887.83.camel@x220> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hPG7eeXeeLd6vKhnNkGbWgGnKLlqUHMEg" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3941 Lines: 114 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hPG7eeXeeLd6vKhnNkGbWgGnKLlqUHMEg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/09/2015 01:59 PM, Paul Bolle wrote: > On Tue, 2015-06-09 at 12:41 +0200, Michal Simek wrote: >> On 06/09/2015 10:15 AM, Paul Bolle wrote: >>> Mistakes I've seen made since I started checking this stuff (a few >>> months ago): >>> - typos in the license ident, say "GPLv2", "GPL V2", or "BSD": genera= tes >>> a warning when module is loaded and taints kernel. People still get t= his >>> wrong. A test in checkpatch for these typos was submitted a while ago= , >>> but it never got added; >> >> Any reason for that? just lost or any problem ? >=20 > Submitter lost interest, I guess. Check > https://lkml.org/lkml/2015/5/22/279 and note that there was no response= =2E will see. >>> - not adding MODULE_LICENSE() to a module: also generates a warning w= hen >>> module is loaded and taints kernel. People still get this wrong; >>> - adding MODULE_LICENSE() to built-in only code: pointless at best, a= nd >>> annoying for reviewers ("Hey, did the submitter intend to write built= -in >>> only code or modular code?"); >>> - using "Dual BSD/GPL" but not a trace of the BSD license blurb in >>> sight, while adding that blurb is one of the very few requirements th= is >>> license actually has; >>> - license mismatch, say comment blurb states "GPL v2 (or later)" but >>> MODULE_LICENSE() ident states "GPL v2" only (or vice versa): very eas= y >>> mistake to make, happens once or twice a week. =20 >> >> What do you mean by vice versa? >> GPL v2 header and MODULE_LICENSE("GPL") should be fine right? >=20 > Not really. The license in the comment at the top of the file is just > GPL v2, while the MODULE_LICENSE ident adds "or later" and thus the > right to "uplicense". So which is it: just "GPL v2" or "GPL v2 (or > later)"? Can't say in that case. ok. Will check all our drivers we have to get it synchronized but I expect that a lot of drivers have problems there. >>> Did I miss anything in that list? >> >> I think you miss MODULE_ALIAS problems. >> https://lkml.org/lkml/2014/3/17/301 >=20 > That's outside of the license stuff, but thanks for thye pointer anyway= =2E >=20 >>> I'm afraid that most of the above can only be caught reliably by >>> attention to detail by submitters and reviewers. That's a pity, becau= se >>> checking for that stuff is about as boring as it gets. (What does tha= t >>> say about me?) >> >> yep. I have never looked at the details about these license module >> stuff. But definitely great to have this list - will record it and kee= p >> my eye on our xilinx drivers. >> >> BTW: Some time ago we discussed SPDX License Identifier which could >> simplify license checking. >> https://lkml.org/lkml/2014/2/21/21 >=20 > I think I saw that fly by. Wasn't that idea shot down? Not sure about current status. Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform --hPG7eeXeeLd6vKhnNkGbWgGnKLlqUHMEg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iEYEARECAAYFAlV22D0ACgkQykllyylKDCEd4wCdGUzerjmaxDEZ2JI575+o0Nmw 0AcAn0Nbw34DUhqCkzYVikbKV8Y93kuh =M88n -----END PGP SIGNATURE----- --hPG7eeXeeLd6vKhnNkGbWgGnKLlqUHMEg-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/