Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932928AbbFIN4b (ORCPT ); Tue, 9 Jun 2015 09:56:31 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:19298 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753066AbbFIN4W (ORCPT ); Tue, 9 Jun 2015 09:56:22 -0400 Date: Tue, 9 Jun 2015 16:55:53 +0300 From: Dan Carpenter To: "DHANAPAL, GNANACHANDRAN (G.)" Cc: "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "mdcasey@chabloom.com" , "behanw@converseincode.com" , "mateusz.kulikowski@gmail.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4] Staging: rtl8192e: Casting correct Endianness Message-ID: <20150609135553.GX28762@mwanda> References: <20150609122508.GA4375@visteon-gnana> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150609122508.GA4375@visteon-gnana> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1100 Lines: 33 On Tue, Jun 09, 2015 at 12:22:27PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote: > From: Gnanachandran Dhanapal > > Casting correct Endianness for __le16 variable used in assignment and > condition check > > Signed-off-by: Gnanachandran Dhanapal > --- > v4: Greg review comments addressed Which ones? > @@ -2244,8 +2244,9 @@ inline int rtllib_rx_assoc_resp(struct rtllib_device *ieee, struct sk_buff *skb, > struct rtllib_assoc_response_frame *assoc_resp; > struct rtllib_hdr_3addr *header = (struct rtllib_hdr_3addr *) skb->data; > > + u16 frame_ctl = le16_to_cpu(header->frame_ctl); > netdev_dbg(ieee->dev, "received [RE]ASSOCIATION RESPONSE (%d)\n", > - WLAN_FC_GET_STYPE(header->frame_ctl)); > + WLAN_FC_GET_STYPE(frame_ctl)); > Blank line in the wrong spot. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/