Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932405AbbFIOHx (ORCPT ); Tue, 9 Jun 2015 10:07:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50488 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbbFIOHo (ORCPT ); Tue, 9 Jun 2015 10:07:44 -0400 Date: Tue, 9 Jun 2015 16:07:42 +0200 From: Karel Zak To: Ryusuke Konishi Cc: Heinz Diehl , linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: NILFS2: double uuid Message-ID: <20150609140742.GH1992@ws.net.home> References: <20150608094559.GB15702@fritha.org> <20150608100835.GA16569@fritha.org> <55756F17.7080603@lab.ntt.co.jp> <20150609.003127.1516615115859573912.konishi.ryusuke@lab.ntt.co.jp> <20150609085329.GF1992@ws.net.home> <5576E44F.5030201@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5576E44F.5030201@lab.ntt.co.jp> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1497 Lines: 43 On Tue, Jun 09, 2015 at 10:04:15PM +0900, Ryusuke Konishi wrote: > $ sudo nilfs-resize -y /dev/sdb1 1G > Partition size = 2146435072 bytes. > Shrink the filesystem size from 2146435072 bytes to 1073741824 bytes. > 128 segments will be truncated from segnum 127. > Moving 103 in-use segments. > progress |***********************************************| > Done. > > $ sudo umount /test > $ sudo mount /dev/sdb1 /test > $ sudo LD_LIBRARY_PATH=/usr/local/lib lsblk -f > NAME FSTYPE LABEL UUID MOUNTPOINT > [...] > sdb > `-sdb1 /test > > This blank state continued until I shrank the partition or > re-extended the filesystem to the partition size. > > Could you consider confining the s_dev_size test only to the > backup superblock ? Hmm... why nilfs-resize does not update the size in the superblock? It seems like nilfs-resize bug. > It seems that we don't have to drop the primary super block > even if s_dev_size doesn't fit to the partition size. Yes, fixed. I have also enabled the s_dev_size check for whole-disk devices only to minimize number of situations when we rely on the s_dev_size. Karel -- Karel Zak http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/