Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753756AbbFIO7N (ORCPT ); Tue, 9 Jun 2015 10:59:13 -0400 Received: from forward8l.mail.yandex.net ([84.201.143.141]:53135 "EHLO forward8l.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751102AbbFIO7B (ORCPT ); Tue, 9 Jun 2015 10:59:01 -0400 From: Andrew Andrianov To: Sudip Mukherjee Cc: Andrew Andrianov , pebolle@tiscali.nl, Arve =?utf-8?B?SGrvv71ubmV277+9Zw==?= , Riley Andrews , Chen Gang , Fabian Frederick , Android Kernel Team , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH v4 0/2] staging: ion: Add generic ion-physmem driver Date: Tue, 9 Jun 2015 17:58:23 +0300 Message-Id: <1433861905-9847-1-git-send-email-andrew@ncrmnt.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <20150603061741.GD4936@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2433 Lines: 65 Sudip Mukherjee писал 03.06.2015 09:15: > On Tue, Jun 02, 2015 at 07:00:39PM +0300, Andrew Andrianov wrote: >> From: Andrew 'Necromant' Andrianov >> >> This patch adds a generic ion driver that allows >> ion heaps to be added via devicetree. It provides >> a simple and generic way to feed physical memory regions >> to ion without writing a custom driver, e.g. >> >> ion_sram: ion@0x00100000 { >> compatible = "ion,physmem"; >> reg = <0x00100000 0x40000>; >> reg-names = "memory"; >> ion-heap-id = <1>; >> ion-heap-type = ; >> ion-heap-align = <0x10>; >> ion-heap-name = "SRAM"; >> }; >> >> Signed-off-by: Andrew Andrianov > > Your From: name and Signed-off-by: name is not matching. Fixed, it's been due to different setups on my home and work PCs. I'm still playing with proper email setup for LKML. > But why you are using this extra From: line? you email header From: > is same as your Signed-off-by. > And since you are adding new files it would be better if you can fix > few checkpatch warnings it has. like: > > CHECK: Prefer kzalloc(sizeof(*ipdev)...) over kzalloc(sizeof(struct > physmem_ion_dev)...) > CHECK: Alignment should match open parenthesis > CHECK: No space is necessary after a cast > CHECK: Please don't use multiple blank lines > regards > sudip I've ran checkpatch again, now with --strict, everything should be clean now. Thanks for your comments. Andrew Andrianov (2): staging: ion: Add generic ion-physmem driver staging: ion: Add ion-physmem documentation Documentation/devicetree/bindings/ion,physmem.txt | 98 +++++++++ drivers/staging/android/ion/Kconfig | 7 + drivers/staging/android/ion/Makefile | 5 +- drivers/staging/android/ion/ion_physmem.c | 229 ++++++++++++++++++++++ include/dt-bindings/ion,physmem.h | 17 ++ 5 files changed, 354 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/ion,physmem.txt create mode 100644 drivers/staging/android/ion/ion_physmem.c create mode 100644 include/dt-bindings/ion,physmem.h -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/